Bug 2266633

Summary:	Review Request: rust-addr - Library for parsing domain names
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Aleksei Bavshin <alebastr89>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	alebastr89, package-review
Target Milestone:	---	Flags:	alebastr89: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/addr
Whiteboard:
Fixed In Version:	rust-addr-0.14.0-1.fc41	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-03-19 17:31:36 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2266634

Description Fabio Valentini 2024-02-28 16:17:51 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-addr.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-addr-0.14.0-1.fc39.src.rpm

Description:
A library for parsing domain names.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-02-28 16:17:54 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=114192064

Comment 2 Fedora Review Service 2024-02-28 16:28:47 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7069140
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266633-rust-addr/fedora-rawhide-x86_64/07069140-rust-addr/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Aleksei Bavshin 2024-03-19 05:52:10 UTC

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (adblock depends on outdated version)
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

Comment 4 Fabio Valentini 2024-03-19 15:50:13 UTC

Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2024-03-19 15:50:48 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-addr

Comment 6 Fabio Valentini 2024-03-19 17:31:36 UTC

Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-89548b54f8