Bug 2266634

Summary: Review Request: rust-adblock - Native Rust module for Adblock Plus syntax
Product: [Fedora] Fedora Reporter: Fabio Valentini <decathorpe>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: ngompa13: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/adblock
Whiteboard:
Fixed In Version: rust-adblock-0.8.8-1.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-03-26 14:25:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2266633    
Bug Blocks: 2213926, 2266623    

Description Fabio Valentini 2024-02-28 16:23:33 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-adblock.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-adblock-0.8.8-1.fc39.src.rpm

Description:
Native Rust module for Adblock Plus syntax (e.g. EasyList, EasyPrivacy)
filter parsing and matching.

Fedora Account System Username: decathorpe

Comment 1 Fedora Review Service 2024-02-28 16:26:17 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7069152
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266634-rust-adblock/fedora-rawhide-x86_64/07069152-rust-adblock/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Neal Gompa 2024-03-22 12:30:10 UTC
[fedora-review-service-build]

Comment 3 Fedora Review Service 2024-03-22 12:49:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7198081
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2266634-rust-adblock/fedora-rawhide-x86_64/07198081-rust-adblock/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Neal Gompa 2024-03-22 14:58:49 UTC
Review notes:

* Packaging largely generated by rust2rpm, simplifying reviews
* Packaging follows Rust packaging guidelines
* Package licensing is correct and valid
* Package builds and installs
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2024-03-26 13:46:25 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-adblock

Comment 6 Fabio Valentini 2024-03-26 14:25:31 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-29fecdb956

Builds for stable branches and EPEL 9 are still running.