Bug 226704
Summary: | Review Request: iasl - Intel acpi compiler | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Till Maas <opensource> |
Component: | Package Review | Assignee: | Andreas Bierfert <andreas.bierfert> |
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | andreas.bierfert, gemi, roland.wolters |
Target Milestone: | --- | Flags: | andreas.bierfert:
fedora-review+
petersen: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2007-03-10 10:43:31 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Till Maas
2007-02-01 00:56:20 UTC
Why do you just build iasl? Is there any special reason why you do not take the whole package? Maybe the other parts can be useful as well?! (In reply to comment #1) > Why do you just build iasl? Is there any special reason why you do not take > the whole package? Maybe the other parts can be useful as well?! I made this package because virtualbox ( http://www.virtualbox.org/ ) needs it, if someone needs the other contents of this package, he may fill a bug report and I will look into adding the other contents. Debian as well only includes iasl ( http://packages.debian.org/testing/source/acpica-unix ) rpmlint: E: iasl description-line-too-long iasl compiles ASL (ACPI Source Language) into AML (ACPI Machine Language), which - reformat to use less than 70 chars, I guess W: iasl invalid-license Intel Software License Agreement W: iasl spurious-executable-perm /usr/share/man/man1/iasl.1.gz - chmod 0644 I would also package the other utilities if possible. Spec URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/iasl.spec SRPM URL: http://www-users.kawo2.rwth-aachen.de/~tmaas/fedora/repo/iasl-20061109-2.src.rpm (In reply to comment #3) > rpmlint: > E: iasl description-line-too-long iasl compiles ASL (ACPI Source Language) into > AML (ACPI Machine Language), which > - reformat to use less than 70 chars, I guess Fixed, has to be less that 80 chars, it was excactly 80 chars. > W: iasl invalid-license Intel Software License Agreement See the comment in the spec file: https://www.redhat.com/archives/fedora-extras-list/2007-January/msg00427.html > W: iasl spurious-executable-perm /usr/share/man/man1/iasl.1.gz > - chmod 0644 fixed > I would also package the other utilities if possible. Do you want to do it or do you use the utitilities? I am not very keen to package them unless they are very needed. If you want to maintain iasl, you can have it. Actually I only wanted to include it to Extras because it is needed by virtualbox, but since I found out that virtualbox needs at least 2 more packages in fedora it exceeds the amount of work that I have free for this. So if you do not need iasl or the other contents of the tarball or want to maintain it, I will close this ticket, soon. > Do you want to do it or do you use the utitilities?
Not really. I once tried iasl for changing DSDT of my laptop (and failed).
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 * rpmlint output is ok as license and tag are approved this way: W: iasl invalid-license Intel Software License Agreement * Package is according to guidelines especially as other distros use iasl as name and intel suggest so as well * specfile name matches %{name} * package is build according to the guidelines * License is ok and approved: https://www.redhat.com/archives/fedora-extras-list/2007-January/msg00427.html, this is also mentioned in the specfile * license field matches actual license * specfile seems to be American English * spec file is legible * source md5sum matches upstream [awjb@alkaid] md5sum acpica-unix-20061109.tar.gz /tmp/acpica-unix-20061109.tar.gz 0ca508dd9bec10fb3b53c72aea6bb6a1 acpica-unix-20061109.tar.gz 0ca508dd9bec10fb3b53c72aea6bb6a1 /tmp/acpica-unix-20061109.tar.gz * builds fine (mock/fc6/x86_64,mock/fc6/i386) * build requires look fine * package does not have locales * no shared libraries in this package * package is not designed to be relocatable * package does not create any directorys * no duplicate files in %files listing * permissions on included files are proper * package includes clean section * use of macros is consistent * content of the package is ok * documentation files do not need -doc subpackage * doc files do not influence runtime * no header files * no static libraries * no .pc files * no .so files * no devel package * package does not contain .la files * package does not contain a gui application * package does not own any directories or files of other packages As the utils do not seem important and could be added at a later point of time if they become of any use (compare to debian/gentoo which only has iasl as well) I consider the package approved. -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQFF8YLXQEQyPsWM8csRAuj9AJ4t3Oqy9RRsiLmG+CMP4Pi/34p04ACfUy7C ULRBOR2aZLnW35O3d+bbKO4= =1y9K -----END PGP SIGNATURE----- New Package CVS Request ======================= Package Name: iasl Short Description: Intel ASL compiler/decompiler Owners: opensource till name Branches: InitialCC: Done For virtualbox also the devel version of yasm is needed, so atm building it for FC-6 does not help anyone. I will import it in FC-6 when someone really needs it. sucessfully built for devel: http://buildsys.fedoraproject.org/logs/fedora-development-extras/29002-iasl-20061109-2.fc7/ |