Bug 2267321

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7095301
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267321-rtmpdump/fedora-rawhide-x86_64/07095301-rtmpdump/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

> Version:        2.4
> Release:        25.%{gitdate}git%{shortcommit}%{?dist}

Please switch to snapshot versioning in the Version field.

Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

> %install
> make CRYPTO=GNUTLS DESTDIR=%{buildroot} prefix=%{_prefix} mandir=%{_mandir} libdir=%{_libdir} install

Please use %make_install and split the long line

(In reply to Neal Gompa from comment #2)
> > Version:        2.4
> > Release:        25.%{gitdate}git%{shortcommit}%{?dist}
> 
> Please switch to snapshot versioning in the Version field.
> 
> Cf.
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
> #_snapshots

No. This is a post-release snapshot and upstream has just announced the intention to release 2.6:
https://lists.mplayerhq.hu/pipermail/rtmpdump/2024-March/002554.html

(In reply to Xavier Bachelot from comment #3)
> > %install
> > make CRYPTO=GNUTLS DESTDIR=%{buildroot} prefix=%{_prefix} mandir=%{_mandir} libdir=%{_libdir} install
> 
> Please use %make_install and split the long line

OK. Anything else?

(In reply to Dominik 'Rathann' Mierzejewski from comment #4)
> (In reply to Neal Gompa from comment #2)
> > > Version:        2.4
> > > Release:        25.%{gitdate}git%{shortcommit}%{?dist}
> > 
> > Please switch to snapshot versioning in the Version field.
> > 
> > Cf.
> > https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
> > #_snapshots
> 
> No. This is a post-release snapshot and upstream has just announced the
> intention to release 2.6:
> https://lists.mplayerhq.hu/pipermail/rtmpdump/2024-March/002554.html

On second thought, OK.

(In reply to Xavier Bachelot from comment #3)
> > %install
> > make CRYPTO=GNUTLS DESTDIR=%{buildroot} prefix=%{_prefix} mandir=%{_mandir} libdir=%{_libdir} install
> 
> Please use %make_install and split the long line

Done. It's no longer so long after the change. :)

Spec URL: https://rathann.fedorapeople.org/review/rtmpdump/rtmpdump.spec
SRPM URL: https://rathann.fedorapeople.org/review/rtmpdump/rtmpdump-2.4%5e20240228gitb7c7976-1.fc41.src.rpm

* Tue Mar 05 2024 Dominik Mierzejewski <dominik> - 2.4^20240228gitb7c7976-1
- use recommended snapshot versioning
- use modern macros

Created attachment 2020126 [details]
The .spec file difference from Copr build 7095301 to 7106479

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7106479
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267321-rtmpdump/fedora-rawhide-x86_64/07106479-rtmpdump/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

[fedora-review-service-build]

- ensure Fedora CFLAGS and LDFLAGS are used consistently

Created attachment 2020134 [details]
The .spec file difference from Copr build 7106479 to 7106653

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7106653
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267321-rtmpdump/fedora-rawhide-x86_64/07106653-rtmpdump/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Maybe missing an explicit BR: make rather than relying on deps ?
Otherwise looks good, will try and do a full review asap.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7158010
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267321-rtmpdump/fedora-rawhide-x86_64/07158010-rtmpdump/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Could you please take a look at the following rpmlint warnings ?
librtmp.x86_64: W: crypto-policy-non-compliance-gnutls-2 /usr/lib64/librtmp.so.1 gnutls_priority_init
librtmp.x86_64: W: crypto-policy-non-compliance-gnutls-1 /usr/lib64/librtmp.so.1 gnutls_priority_set_direct

See https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/

And also :
librtmp.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/librtmp.so.1

Both shall probably at least be notified to upstream.

(In reply to Xavier Bachelot from comment #14)
> Maybe missing an explicit BR: make rather than relying on deps ?

Good point, will add when importing.

> Otherwise looks good, will try and do a full review asap.

Thanks!

(In reply to Xavier Bachelot from comment #17)
> Could you please take a look at the following rpmlint warnings ?
> librtmp.x86_64: W: crypto-policy-non-compliance-gnutls-2
> /usr/lib64/librtmp.so.1 gnutls_priority_init
> librtmp.x86_64: W: crypto-policy-non-compliance-gnutls-1
> /usr/lib64/librtmp.so.1 gnutls_priority_set_direct
> 
> See https://docs.fedoraproject.org/en-US/packaging-guidelines/CryptoPolicies/
> 
> And also :
> librtmp.x86_64: W: binary-or-shlib-calls-gethostbyname
> /usr/lib64/librtmp.so.1
> 
> Both shall probably at least be notified to upstream.

They are valid and I sent them upstream. However, I wonder if RTMP
even supports IPv6 or if there are specific old crypto
requirements at work here.

rtmpdump upstream advice is not to include it in Fedora at all.

Only two RPM Fusion packages depend on rtmpdump: get-flash-videos and qarte.

First is dead (last commit 4 years ago) and the second is specific to one website (arte.tv).

So... probably not worth packaging. Withdrawing review request.

There seems to be some problem with the following file.
SRPM URL: https://rathann.fedorapeople.org/review/rtmpdump/rtmpdump-2.4%5E20240228gitb7c7976-1.fc41.src.rpm
Fetching it results in a 404 Not Found error.
Please make sure the URL is correct and publicly available.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Reopening.

Spec URL: https://rathann.fedorapeople.org/review/rtmpdump/rtmpdump.spec
SRPM URL: https://rathann.fedorapeople.org/review/rtmpdump/rtmpdump-2.6~20240301git6f6bb13-1.fc45.src.rpm

rebased on top of current RPM Fusion package:
- use proper macros
- BuildRequire make explicitly
- ensure Fedora CFLAGS and LDFLAGS are used

Taking this review.

Spec review:

> # The tools are GPLv2+. The library is LGPLv2+, see below.
> License:        GPL-2.0-or-later

This needs a "SourceLicense" stanza, since the source code is both.

> %package -n librtmp-devel
> Summary:        Files for librtmp development
> License:        LGPLv2+

License tag needs to be updated to SPDX.

> %autosetup -p1 -n %{name}-%{commit}

This can be simplified to "%autosetup -C -p1" unless you want to ship this in EPEL.

> %make_build SYS=posix CRYPTO=GNUTLS SHARED=yes XCFLAGS="%{optflags}" XLDFLAGS="%{build_ldflags}"

XCFLAGS should use "%{build_cflags}".

Spec URL: https://rathann.fedorapeople.org/review/rtmpdump/rtmpdump.spec
SRPM URL: https://rathann.fedorapeople.org/review/rtmpdump/rtmpdump-2.6~20240301git6f6bb13-2.fc45.src.rpm

    - use SourceLicense: tag to describe source license accurately
    - use SPDX expression for -devel subpackage license
    - use build_cflags instead of optflags

[fedora-review-service-build]

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10618238
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267321-rtmpdump/fedora-rawhide-x86_64/10618238-rtmpdump/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Copr build:
https://copr.fedorainfracloud.org/coprs/build/10618240
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2267321-rtmpdump/fedora-rawhide-x86_64/10618240-rtmpdump/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

At this point, it looks good to me.

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/rtmpdump
Monitoring:
Anitya project is accessible by this link 
`https://release-monitoring.org/project/141551`
 you can modify it manually.
Package wasn't created in Anitya, reason: `Bad Request, some necessary arguments were not provided.`.

FEDORA-2026-e891f226fd (gstreamer1-plugins-bad-free-1.28.4-3.fc44 and rtmpdump-2.6-4.fc44) has been submitted as an update to Fedora 44.
https://bodhi.fedoraproject.org/updates/FEDORA-2026-e891f226fd

FEDORA-2026-e891f226fd has been pushed to the Fedora 44 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2026-e891f226fd`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2026-e891f226fd

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

FEDORA-2026-e891f226fd (gstreamer1-plugins-bad-free-1.28.4-3.fc44 and rtmpdump-2.6-4.fc44) has been pushed to the Fedora 44 stable repository.
If problem still persists, please make note of it in this bug report.