Bug 2269403

Summary:	Duplicate repositories in content view versions warning is always active
Product:	Red Hat Satellite	Reporter:	Samir Jha <sajha>
Component:	Subscription Management	Assignee:	satellite6-bugs <satellite6-bugs>
Status:	CLOSED MIGRATED	QA Contact:	Satellite QE Team <sat-qe-bz-list>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	6.10.0	CC:	ahumbe, pcreech, rlavi
Target Milestone:	Unspecified	Keywords:	EasyFix, MigratedToJIRA, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-06-06 17:25:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Samir Jha 2024-03-13 17:46:02 UTC

UI Bug: When publishing a new CCV version, I always see the following warning/info message:

Duplicate repositories in content view versions
Repositories common to the selected content view versions will merge, resulting in a composite content view that is a union of all content from each of the content view versions.

This is displayed whether or not there are any duplicate constituent CV repositories.

I am pretty sure the bug is this line: https://github.com/Katello/katello/blob/master/webpack/scenes/ContentViews/Publish/CVPublishForm.js#L69

I am pretty sure it needs to be && instead of ||. Right now `duplicateRepos` is normally an empty list, so `duplicateRepos !== null` is true making the entire disjunction true in the case when the message should not be displayed.

Since I don't have the dev environment/experience for fixing js bugs, I am hoping someone else can quickly verify the fix and open a PR.

Comment 1 Samir Jha 2024-03-13 17:46:05 UTC

Created from redmine issue https://projects.theforeman.org/issues/37240

Comment 2 Samir Jha 2024-03-13 17:46:07 UTC

Upstream bug assigned to None

Comment 5 Eric Helms 2024-06-06 17:25:54 UTC

This BZ has been automatically migrated to the issues.redhat.com Red Hat Issue Tracker. All future work related to this report will be managed there.

Due to differences in account names between systems, some fields were not replicated.  Be sure to add yourself to Jira issue's "Watchers" field to continue receiving updates and add others to the "Need Info From" field to continue requesting information.

To find the migrated issue, look in the "Links" section for a direct link to the new issue location. The issue key will have an icon of 2 footprints next to it, and begin with "SAT-" followed by an integer.  You can also find this issue by visiting https://issues.redhat.com/issues/?jql= and searching the "Bugzilla Bug" field for this BZ's number, e.g. a search like:

"Bugzilla Bug" = 1234567

In the event you have trouble locating or viewing this issue, you can file an issue by sending mail to rh-issues. You can also visit https://access.redhat.com/articles/7032570 for general account information.