Bug 2269955

Summary:	Following a server crash, octavia_rsyslog is not restarting due to same pid as pid in pidfile
Product:	Red Hat OpenStack	Reporter:	David Hill <dhill>
Component:	openstack-tripleo-heat-templates	Assignee:	Gregory Thiemonge <gthiemon>
Status:	CLOSED ERRATA	QA Contact:	Arkady Shtempler <ashtempl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	17.1 (Wallaby)	CC:	beagles, gthiemon, jslagle, mariel, mburns
Target Milestone:	z4	Keywords:	Triaged
Target Release:	17.1
Hardware:	x86_64
OS:	All
Whiteboard:
Fixed In Version:	openstack-tripleo-heat-templates-14.3.1-17.1.20240515123749.e7c7ce3.el8ost	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-11-21 09:31:18 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Hill 2024-03-17 15:35:29 UTC

Description of problem:
Following a server crash, octavia_rsyslog is not restarting due to same pid as pid in pidfile

2024-03-17T10:11:22.855376921+05:30 stderr F rsyslogd: pidfile '/var/run/rsyslogd.pid' and pid 7 already exist.
2024-03-17T10:11:22.855376921+05:30 stderr F If you want to run multiple instances of rsyslog, you need to specify
2024-03-17T10:11:22.855376921+05:30 stderr F different pid files for them (-i option).
2024-03-17T10:11:22.855376921+05:30 stderr F rsyslogd: run failed with error -3000 (see rsyslog.h or try https://www.rsyslog.com/e/3000 to learn what that number means)

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1. send c to sysrq-trigger
2.
3.

Actual results:
ocatavia_rsyslog is not starting

Expected results:
maybe it should

Additional info:

Comment 1 David Hill 2024-03-17 16:55:55 UTC

commit c2cf9f6a3963eb59cf53643f4abab2e4f69baa90
Author: David Hill <dhill>
Date:   Sun Mar 17 12:49:55 2024 -0400

    Do not create a pidfile in the container.
    
    Do not create a pidfile in the container as when the server crashes
    it will try to see if pidfile exists and if pid is running while
    rsyslogd starts up.  Given we're managing pid file with systemd, this
    should solve this situation.
    
    Change-Id: I5a479c85004d58df7f201becee96b49584adbb0e

diff --git a/deployment/octavia/octavia-health-manager-container-puppet.yaml b/deployment/octavia/octavia-health-manager-container-puppet.yaml
index 18e4ae1d0..3aa6f2baa 100644
--- a/deployment/octavia/octavia-health-manager-container-puppet.yaml
+++ b/deployment/octavia/octavia-health-manager-container-puppet.yaml
@@ -165,7 +165,7 @@ outputs:
               owner: octavia:octavia
               recurse: true
         /var/lib/kolla/config_files/octavia_rsyslog.json:
-          command: /usr/sbin/rsyslogd -n
+          command: /usr/sbin/rsyslogd -n -iNONE
           config_files:
             - source: "/var/lib/kolla/config_files/src/*"
               dest: "/"

Comment 14 errata-xmlrpc 2024-11-21 09:31:18 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (RHOSP 17.1.4 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2024:9973