Bug 227055

The latest version is now 0.93.

You might also want to start by cleaning up the spec file, since it still
contains a lot of jpackage-isms, which I don't think are really relevant to
Fedora (jpp release tag, long copyright notice for instance).

Clearing FE-NEW since this is under review, although it's been an awfully long
time without any review comments.

*** Bug 332871 has been marked as a duplicate of this bug. ***

Updated to the new upstream release:
http://langel.fedorapeople.org/fop/fop.spec
http://langel.fedorapeople.org/fop/fop-0.94-1.src.rpm

Updated these files again:
http://langel.fedorapeople.org/fop/fop.spec
http://langel.fedorapeople.org/fop/fop-0.94-1.src.rpm

Just to clarify, running the testsuite in %build is not a good idea because not
all tests pass, causing the build to fail.

- rpmlint:

$ rpmlint fop-0.94-1.src.rpm

$ rpmlint /notnfs/fitzsim/rpmbuild/RPMS/noarch/fop-0.94-1.noarch.rpm
fop.noarch: W: class-path-in-manifest /usr/share/java/fop-0.94.jar

The Class-Path field in this manifest is added by fop-manifest.patch, but it
should not be:

$ rpmlint -i RPMS/noarch/fop-0.94-1.noarch.rpm 
fop.noarch: W: class-path-in-manifest /usr/share/java/fop-0.94.jar
The META-INF/MANIFEST file in the jar contains a hardcoded Class-Path.
These entries do not work with older Java versions and even if they do work,
they are inflexible and usually cause nasty surprises.

- package name fine

- spec file name matches package name

- package meets packaging guidelines

The BuildRoot line is non-standard.

- package meets licensing guidelines

- license field matches actual license

- license marked %doc

- spec file uses American English

- spec file legible

%define section devel

Remove the top two lines.

(cd $RPM_BUILD_ROOT%{_javadir} && for jar in *-%{version}*; do ln -sf ${jar}
`echo $jar| sed "s|-%{version}||g"`; done)

This should be done as a pushd/popd block.  In general, spec file lines should
wrap at the 80th column.

- source and upstream md5sum match

- package builds successfully on i386

- all build requirements listed

No, none are listed.

- no locales

- no shared libraries for ldconfig

- not relocatable

- directories:
  - owns %{_javadocdir}/%{name}-%{version} and %{_datadir}/fop, which
    it creates
  - requires jpackage-utils for %{_javadir} into which it installs jar files

- no duplicate files

- permissions

Replace 0644 and 0755 in the %defattr lines with - to use the default values.

- %clean section fine

- consistent use of macros

- contains code

- doc subpackage

- docs don't affect runtime

- no header files

- no static libraries

- no pkgconfig files

- no library files

- no devel package

- no .la files

- no desktop files

- doesn't own other packages' directories

- removes buildroot at start of %install

- filenames valid UTF-8

- license text included

- no description/summary translations available

- builds in mock on i386

No.  Missing BuildRequires lines cause the build to fail.

- other architectures not tested, but this is a noarch package

- did not test proper functioning, since fop requires batik

- no scriptlets

- javadoc package doesn't require base package -- fine

- no pkgconfig files

- packages required, rather than individual files

Updated these files again:
http://langel.fedorapeople.org/fop/fop.spec
http://langel.fedorapeople.org/fop/fop-0.94-1.src.rpm

With:

export JAVA_HOME=/usr/lib/jvm/java-icedtea

in the build environment, I can build with rpmbuild on i386.

When I try /usr/bin/fop, I get this:

$ /usr/bin/fop 
Exception in thread "main" java.lang.NoClassDefFoundError:
org/apache/commons/logging/LogFactory
        at org.apache.fop.apps.FopFactory.<clinit>(FopFactory.java:63)
        at org.apache.fop.cli.CommandLineOptions.<init>(CommandLineOptions.java:100)
        at org.apache.fop.cli.Main.startFOP(Main.java:153)
        at org.apache.fop.cli.Main.main(Main.java:196)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.logging.LogFactory
        at java.net.URLClassLoader$1.run(URLClassLoader.java:220)
        at java.security.AccessController.doPrivileged(Native Method)
        at java.net.URLClassLoader.findClass(URLClassLoader.java:208)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:323)
        at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:294)
        at java.lang.ClassLoader.loadClass(ClassLoader.java:268)
        at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:336)
        ... 4 more

I tested out the mock build, and uploaded the new spec file and srpm.
http://langel.fedorapeople.org/fop/fop.spec
http://langel.fedorapeople.org/fop/fop-0.94-1.src.rpm


Also, to run fop you need to set CLASSPATH up properly:
export CLASSPATH=$CLASSPATH:/usr/share/java/commons-logging.jar:
/usr/share/java/xmlgraphics-commons.jar:
/usr/share/java/avalon-framework.jar:
/usr/share/java/batik-all-1.7.jar

Created attachment 269141 [details]
Fixed wrapper script.

/usr/bin/fop failed on startup due to the classpath issues you mentioned.  Here
is an updated wrapper script that handles all the classpath setup.

Approved.

Please update the wrapper script before committing.

Thanks

Uploaded the new spec file and srpm.
http://langel.fedorapeople.org/fop/fop.spec
http://langel.fedorapeople.org/fop/fop-0.94-1.src.rpm

New Package CVS Request
=======================
Package Name: fop
Short Description: XSL-driven print formatter
Owners: langel
Branches: F-8
InitialCC: fitzsim
Cvsextras Commits: yes

(corrected the Summary to have just the package name in it, you shouldn't put
versions in there). 

cvs done. 

Can we please have an update pushed to the F-8 branch via bodhi?  Thanks.

I didn't even see a build in bodhi:

http://koji.fedoraproject.org/koji/packageinfo?packageID=5354

even though the CVS F-8 branch is done.