Bug 227058
Summary: | Review Request: gnu-trove-1.0.2-4jpp - High performance collections for Java | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rafael H. Schloming <rafaels> | ||||
Component: | Package Review | Assignee: | Nuno Santos <nsantos> | ||||
Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | aortega, tross | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2007-03-08 21:42:42 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 201449 | ||||||
Attachments: |
|
Description
Rafael H. Schloming
2007-02-02 17:36:36 UTC
Please rename this package to gnu-trove (i.e., replace the '.' in the name with a '-'). Created attachment 147926 [details]
spec file already renamed
MUST: X remove %define short-name and simply use trove in %Name X release should be of form: Xjpp.Y%{?dist} X no explanation of how source0 generated or where fetched from X correct buildroot - should be: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) X rpmlint on <this package>.srpm gives no output [jjohnstn@vermillion Desktop]$ rpmlint gnu-trove-1.0.2-5jpp.src.rpm W: gnu-trove non-standard-group Development/Libraries/Java E: gnu-trove unknown-key GPG#c431416d W: gnu-trove unversioned-explicit-provides gnu.trove W: gnu-trove unversioned-explicit-obsoletes gnu.trove W: gnu-trove unversioned-explicit-provides gnu.trove-javadoc W: gnu-trove unversioned-explicit-obsoletes gnu.trove-javadoc W: gnu-trove mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 52) X Vendor tag should not be used X make sure lines are <= 80 characters * verify the final provides and requires of the binary RPMs * run rpmlint on the binary RPMs [jjohnstn@vermillion noarch]$ rpmlint gnu-trove-1.0.2-5jpp.noarch.rpm W: gnu-trove non-standard-group Development/Libraries/Java [jjohnstn@vermillion noarch]$ rpmlint gnu-trove-javadoc-1.0.2-5jpp.noarch.rpm W: gnu-trove-javadoc non-standard-group Development/Documentation W: gnu-trove-javadoc dangerous-command-in-%post rm W: gnu-trove-javadoc dangerous-command-in-%postun rm Comments handled. %define short-name was used elsewhere. Only removed it from %Name. http://www.vermillionskye.com/downloads/gnu-trove-1.0.2-5jpp.1.src.rpm http://www.vermillionskye.com/downloads/gnu-trove.spec $ rpm -qp --requires RPMS/noarch/gnu-trove-1.0.2-5jpp.1.noarch.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 $ rpm -qp --provides RPMS/noarch/gnu-trove-1.0.2-5jpp.1.noarch.rpm gnu.trove <= 0:1.0.2-5jpp.1 gnu-trove = 0:1.0.2-5jpp.1 $ rpm -qp --requires RPMS/noarch/gnu-trove-javadoc-1.0.2-5jpp.1.noarch.rpm rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(VersionedDependencies) <= 3.0.3-1 $ rpm -qp --provides RPMS/noarch/gnu-trove-javadoc-1.0.2-5jpp.1.noarch.rpm gnu.trove-javadoc <= 0:1.0.2-5jpp.1 gnu-trove-javadoc = 0:1.0.2-5jpp.1 APPROVED. Updated the subject line so we find it if we ever go looking for gnu-trove (with the '-'). No longer needed for maven2 packaging. |