Bug 2270592
| Summary: | Review Request: keydb - keydb is a multi-threaded fork of redis | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Wright <jonathan> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, fschwarz, leonfauster, ngompa13, package-review, vwfoxguru | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://keydb.dev/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-04-06 01:41:17 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Jonathan Wright
2024-03-21 05:20:49 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7191618 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270592-keydb/fedora-rawhide-x86_64/07191618-keydb/fedora-review/review.txt Found issues: - Systemd service file(s) in keydb Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Scriptlets/#_scriptlets Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Spec review:
> %post
> %systemd_post %{name}.service
> %systemd_post %{name}-sentinel.service
>
>
> %postun
> %systemd_postun_with_restart %{name}.service
> %systemd_postun_with_restart %{name}-sentinel.service
You're missing the preun scriptlets. Please add them.
The client (cli) and the server are calling home (api.keydb.dev). The server config has a "enable-motd no" that disable this, leaving the client doing it. It seams that they have a build switch "make NO_MOTD=yes". Not tested ... Just to consolidate this info (already send via mail, sorry to break the medium): One thing that shows up, are the drop-in directories and files of redis: # rpm -ql redis |grep systemd /etc/systemd/system/redis-sentinel.service.d /etc/systemd/system/redis-sentinel.service.d/limit.conf /etc/systemd/system/redis.service.d /etc/systemd/system/redis.service.d/limit.conf Both add a LimitNOFILE=10240 to the service section. The same is done by upstream https://download.keydb.dev/pkg/open_source/rpm/centos8/x86_64/ They have some security stuff more in the main unit file but both (redis, upstream keydb) do update the above limits. (In reply to Neal Gompa from comment #3) > You're missing the preun scriptlets. Please add them. I was laying in bed last night and it hit me that I forgot this :( (In reply to Leon Fauster from comment #4) > The client (cli) and the server are calling home (api.keydb.dev). The server > config has a "enable-motd no" > that disable this, leaving the client doing it. It seams that they have a > build switch "make NO_MOTD=yes". Not tested ... Good catch, testing the compile-time flag to make sure it fully disables it. (In reply to Leon Fauster from comment #5) > Just to consolidate this info (already send via mail, sorry to break the > medium): > > One thing that shows up, are the drop-in directories and files > of redis: > > # rpm -ql redis |grep systemd > /etc/systemd/system/redis-sentinel.service.d > /etc/systemd/system/redis-sentinel.service.d/limit.conf > /etc/systemd/system/redis.service.d > /etc/systemd/system/redis.service.d/limit.conf > > Both add a LimitNOFILE=10240 to the service section. > > The same is done by upstream > > https://download.keydb.dev/pkg/open_source/rpm/centos8/x86_64/ > > They have some security stuff more in the main unit file but both > (redis, upstream keydb) do update the above limits. Adding this. Will have a new build shortly. Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/keydb/epel-9-x86_64/07193662-keydb/keydb.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/keydb/epel-9-x86_64/07193662-keydb/keydb-6.3.4-1.el9.src.rpm Created attachment 2022940 [details]
The .spec file difference from Copr build 7191618 to 7193730
Copr build: https://copr.fedorainfracloud.org/coprs/build/7193730 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270592-keydb/fedora-rawhide-x86_64/07193730-keydb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I don't see any %build section
So package is built during %{make_install} which have no parallelism option (-j)
So the build is quite slow.
(In reply to Remi Collet from comment #10) > I don't see any %build section > > So package is built during %{make_install} which have no parallelism option > (-j) > So the build is quite slow. Hah good catch. My only explanation for that is that I started this spec file back in 2022 and I really don't know why I didn't make a %build section then and didn't even notice I didn't have one. Wish someone called me out on this sooner and it'd have saved me a lot of time while working on the spec and waiting on mockbuild and COPR builds lol. Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/keydb/fedora-rawhide-x86_64/07193969-keydb/keydb.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/keydb/fedora-rawhide-x86_64/07193969-keydb/keydb-6.3.4-1.fc41.src.rpm Created attachment 2022945 [details]
The .spec file difference from Copr build 7193730 to 7194011
Copr build: https://copr.fedorainfracloud.org/coprs/build/7194011 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270592-keydb/fedora-rawhide-x86_64/07194011-keydb/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled and recorded * No serious issues from rpmlint PACKAGE APPROVED. :) The Pagure repository was created at https://src.fedoraproject.org/rpms/keydb FEDORA-EPEL-2024-3a9b69d18c (keydb-6.3.4-2.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-3a9b69d18c FEDORA-2024-3e94473821 (keydb-6.3.4-2.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-3e94473821 FEDORA-2024-0a13c27363 (keydb-6.3.4-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0a13c27363 FEDORA-2024-0a38b15e34 (keydb-6.3.4-2.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0a38b15e34 FEDORA-EPEL-2024-687a561785 (keydb-6.3.4-2.el8) has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-687a561785 FEDORA-2024-fb1f3ce6e2 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-fb1f3ce6e2` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-fb1f3ce6e2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-c36ab1c701 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c36ab1c701` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c36ab1c701 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-0267e2a685 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-0267e2a685 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-60bac4845e has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-60bac4845e See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-e7ca3a9f30 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e7ca3a9f30` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e7ca3a9f30 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-c36ab1c701 (keydb-6.3.4-3.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-0267e2a685 (keydb-6.3.4-3.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-60bac4845e (keydb-6.3.4-3.el8) has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-fb1f3ce6e2 (keydb-6.3.4-3.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-e7ca3a9f30 (keydb-6.3.4-3.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |