Bug 227074
| Summary: | Review Request: jrexx-1.1.1-3jpp - Automaton based regluar expression API for Java | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rafael H. Schloming <rafaels> | ||||
| Component: | Package Review | Assignee: | Matt Wringe <mwringe> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | klee, tross | ||||
| Target Milestone: | --- | Flags: | overholt:
fedora-review+
kevin: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-07-06 21:28:53 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Rafael H. Schloming
2007-02-02 17:41:53 UTC
Review comments:
* incorrect buildroot
- should be:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* license text not included in package and marked with %doc
* rpmlint on <this package>.srpm gives some output
W: jrexx non-standard-group Development/Libraries/Java
E: jrexx unknown-key GPG#c431416d
W: jrexx setup-not-quiet
* changelog should be in one of these formats:
* Fri Jun 23 2006 Jesse Keating <jkeating> - 0.6-4
- And fix the link syntax.
* Fri Jun 23 2006 Jesse Keating <jkeating> 0.6-4
- And fix the link syntax.
* Fri Jun 23 2006 Jesse Keating <jkeating>
- 0.6-4
- And fix the link syntax.
* Vendor tag should not be used
* some lines are > 80 characters
* does not use macros appropriately and consistently
- ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
Comments handled. No license txt but license is specified on web-site. There was no issue with changelog nor the macros. http://www.vermillionskye.com/downloads/jrexx-1.1.1-3jpp.1.src.rpm http://www.vermillionskye.com/downloads/jrexx.spec Created attachment 147995 [details]
patch to fix remaining issues
Remove section free
Remove Distribution
Patch applied. Also modified command line that was > 80 chars and modified changelog entries to use @ symbol. http://www.vermillionskye.com/downloads/jrexx-1.1.1-3jpp.1.src.rpm http://www.vermillionskye.com/downloads/jrexx.spec (In reply to comment #4) > Patch applied. Also modified command line that was > 80 chars and modified > changelog entries to use @ symbol. > > http://www.vermillionskye.com/downloads/jrexx-1.1.1-3jpp.1.src.rpm > http://www.vermillionskye.com/downloads/jrexx.spec If you change the email addresses back, I think I'll approve it :) Done. http://www.vermillionskye.com/downloads/jrexx-1.1.1-3jpp.1.src.rpm http://www.vermillionskye.com/downloads/jrexx.spec APPROVED Thanks, Jeff! Matt, I believe you're going to be the owner, right? When you've built it, I'll close this rawhide. Was someone going to make a CVS request and get this checked in? Matt? This was one of the packages that we thought was needed for maven2, but we later determined it wasn't required at this time. This package is no longer needed for maven at this time, since it has been reviewed and passed, I am setting the cvs request New Package CVS Request ======================= Package Name: jrexx Short Description: Automaton based regluar expression API for Java Owners: mwringe Branches: devel cvs done. Build into devel. Closing as NEXTRELEASE |