Bug 2270856

Summary:	Review Request: gap-pkg-fplsa - Finitely presented Lie algebras
Product:	[Fedora] Fedora	Reporter:	Jerry James <loganjerry>
Component:	Package Review	Assignee:	Matthieu Saulnier <msaulnier>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	msaulnier, package-review
Target Milestone:	---	Keywords:	AutomationTriaged
Target Release:	---	Flags:	msaulnier: fedora-review+
Hardware:	All
OS:	Linux
URL:	https://gap-packages.github.io/FPLSA/
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-04-19 21:33:47 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jerry James 2024-03-21 20:51:56 UTC

Spec URL: https://jjames.fedorapeople.org/gap-pkg-fplsa/gap-pkg-fplsa.spec
SRPM URL: https://jjames.fedorapeople.org/gap-pkg-fplsa/gap-pkg-fplsa-1.2.6-1.fc41.src.rpm
Fedora Account System Username: jjames
Description: When K is a finitely-presented Lie algebra, the GAP operation IsomorphismSCTableAlgebra can be used to make the structure of K explicit, in the form of an isomorphic algebra given by structure constants, which is much more amenable to further computations.

This GAP package installs an alternative method for this operation, which calls an external C program (fplsa version 4.0) to do the hard part of the computation.  This speeds up the calculation and permits larger problems to be attempted.  The external program has much additional functionality which is not used by the present version of the package.

NOTE: Upstream built their software on the assumption that GAP packages live in a user's home directory.  There is an initialization (.ini) file that, in an RPM setting, would become unwritable for ordinary users.  Therefore, I have added a patch so that the package looks for ~/.config/gap/fplsa4.ini, /etc/fplsa4.ini, and fplsa4.ini in the installed package directory, in that order.

Comment 1 Fedora Review Service 2024-03-21 21:02:18 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7194507
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2270856-gap-pkg-fplsa/fedora-rawhide-x86_64/07194507-gap-pkg-fplsa/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Matthieu Saulnier 2024-03-29 14:49:13 UTC

I see 4 issues in the package:

[!]: Package consistently uses macros (instead of hard-coded directory
     names). See below:

- The Name: tag is not using %{pkgname} macro (like in your other package)

- in %%install section: src/fplsa4.ini

- in %%files section, macro again: %{pkgname}4.ini

Also, the doc package seems to be empty, this is an explanation why:

you are creating the doc directory with the %{upname} macro, but the scriptlet "%gap_copy_docs" is not using the same path.

the scriptlet is printing its own path during the build: /builddir/build/BUILDROOT/gap-pkg-fplsa-1.2.6-1.fc40.x86_64/usr/lib64/gap/pkg/fplsa/doc

(see, there is no upper case in the path)

the result is: the directory %{gap_archdir}/pkg/%{upname}/doc is correctly packaged, but it is empty, AND there is no rpmbuild warning about the unpackaged files remaining in the buildroot directory (don't know why).

Comment 3 Jerry James 2024-04-01 19:49:05 UTC

Thank you for the review, Matthieu.

(In reply to Matthieu Saulnier from comment #2)
> I see 4 issues in the package:
> 
> [!]: Package consistently uses macros (instead of hard-coded directory
>      names). See below:
> 
> - The Name: tag is not using %{pkgname} macro (like in your other package)

That isn't what "consistently uses macros" means.  As the parenthetical remark indicates, it's talking about using %{_bindir} instead of "/usr/bin", %{_libdir} instead of "/usr/lib" or "/usr/lib64", etc.  Nevertheless, you are correct that I have written "Name: gap-pkg-%{pkgname}" in other gap spec files, so I should be consistent with myself. :-)  Fixed.

> - in %%install section: src/fplsa4.ini
> 
> - in %%files section, macro again: %{pkgname}4.ini

Hmmm, %files has "%config(noreplace) %{_sysconfdir}/fplsa4.ini" in my copy.  Did I upload a version that has "%{pkgname}4.ini"?  In any case, the version I just uploaded consistently uses the name "fplsa4.ini" everywhere.

> Also, the doc package seems to be empty, this is an explanation why:

Oops!  Yes, %gap_copy_docs needs a -n argument.  Fixed.

The new spec and source rpm files are at the same URLs as above.

Comment 4 Matthieu Saulnier 2024-04-07 12:13:21 UTC

(In reply to Jerry James from comment #3)
> (In reply to Matthieu Saulnier from comment #2)
> > - in %%install section: src/fplsa4.ini
> > 
> > - in %%files section, macro again: %{pkgname}4.ini
> 
> Hmmm, %files has "%config(noreplace) %{_sysconfdir}/fplsa4.ini" in my copy. 
> Did I upload a version that has "%{pkgname}4.ini"?  In any case, the version
> I just uploaded consistently uses the name "fplsa4.ini" everywhere.
> 
Fine. That's not a blocker anyway.

Comment 5 Matthieu Saulnier 2024-04-07 14:48:58 UTC

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

Observations
============

- All the issues mentionned before, has been fixed.

- The rpmlint warning:
  gap-pkg-fplsa.spec:59: W: configure-without-libdir-spec
  is justified and commented in the SPEC file.

- GAP documentation MUST be installed under %{gap_libdir}/pkg or %{gap_archdir}/pkg, this is done correctly in your package. It produces a lot of rpmlint complaints. But it is matching the Guideline 100%.

Ref: https://docs.fedoraproject.org/en-US/packaging-guidelines/GAP/

===== MUST items =====

C/C++:
[x]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU General Public License, Version
     2", "*No copyright* GNU General Public License, Version 2", "*No
     copyright* GNU General Public License v2.0 or later". 160 files have
     unknown license.
[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
     Note: %%autochangelog macro used.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
     Note: ExcludeArch used is optional.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: %config files are marked noreplace or the reason is justified.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: No %config files under /usr.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 4934 bytes in 2 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on debuginfo package(s).
     Note: No rpmlint messages.
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gap-pkg-fplsa-1.2.6-1.fc40.x86_64.rpm
          gap-pkg-fplsa-doc-1.2.6-1.fc40.x86_64.rpm
          gap-pkg-fplsa-debuginfo-1.2.6-1.fc40.x86_64.rpm
          gap-pkg-fplsa-debugsource-1.2.6-1.fc40.x86_64.rpm
          gap-pkg-fplsa-1.2.6-1.fc40.src.rpm
======================================================= rpmlint session starts =======================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpuvzmynz2')]
checks: 32, packages: 5

gap-pkg-fplsa-doc.x86_64: W: only-non-binary-in-usr-lib
gap-pkg-fplsa-doc.x86_64: W: no-documentation
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/chooser.html /usr/share/gap/pkg/GAPDoc/styles/chooser.html
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/lefttoc.css /usr/share/gap/pkg/GAPDoc/styles/lefttoc.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/manual.css /usr/share/gap/pkg/GAPDoc/styles/manual.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/manual.js /usr/share/gap/pkg/GAPDoc/styles/manual.js
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/nocolorprompt.css /usr/share/gap/pkg/GAPDoc/styles/nocolorprompt.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/ragged.css /usr/share/gap/pkg/GAPDoc/styles/ragged.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/rainbow.js /usr/share/gap/pkg/GAPDoc/styles/rainbow.js
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/times.css /usr/share/gap/pkg/GAPDoc/styles/times.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/toggless.css /usr/share/gap/pkg/GAPDoc/styles/toggless.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/toggless.js /usr/share/gap/pkg/GAPDoc/styles/toggless.js
gap-pkg-fplsa.spec:59: W: configure-without-libdir-spec
================= 5 packages and 0 specfiles checked; 0 errors, 13 warnings, 31 filtered, 0 badness; has taken 0.5 s =================




Rpmlint (debuginfo)
-------------------
Checking: gap-pkg-fplsa-debuginfo-1.2.6-1.fc40.x86_64.rpm
======================================================= rpmlint session starts =======================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpz6up4i06')]
checks: 32, packages: 1

================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 5 filtered, 0 badness; has taken 0.1 s ==================





Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 4

gap-pkg-fplsa-doc.x86_64: W: only-non-binary-in-usr-lib
gap-pkg-fplsa-doc.x86_64: W: no-documentation
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/chooser.html /usr/share/gap/pkg/GAPDoc/styles/chooser.html
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/lefttoc.css /usr/share/gap/pkg/GAPDoc/styles/lefttoc.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/manual.css /usr/share/gap/pkg/GAPDoc/styles/manual.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/manual.js /usr/share/gap/pkg/GAPDoc/styles/manual.js
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/nocolorprompt.css /usr/share/gap/pkg/GAPDoc/styles/nocolorprompt.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/ragged.css /usr/share/gap/pkg/GAPDoc/styles/ragged.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/rainbow.js /usr/share/gap/pkg/GAPDoc/styles/rainbow.js
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/times.css /usr/share/gap/pkg/GAPDoc/styles/times.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/toggless.css /usr/share/gap/pkg/GAPDoc/styles/toggless.css
gap-pkg-fplsa-doc.x86_64: W: dangling-symlink /usr/lib64/gap/pkg/FPLSA/doc/toggless.js /usr/share/gap/pkg/GAPDoc/styles/toggless.js
 4 packages and 0 specfiles checked; 0 errors, 12 warnings, 28 filtered, 0 badness; has taken 0.4 s 



Source checksums
----------------
https://github.com/gap-packages/FPLSA/archive/v1.2.6/FPLSA-1.2.6.tar.gz :
  CHECKSUM(SHA256) this package     : e7c31c03b6fea06f2842ed0738da76bf97770baef46855b47d79d276ea1f1b20
  CHECKSUM(SHA256) upstream package : e7c31c03b6fea06f2842ed0738da76bf97770baef46855b47d79d276ea1f1b20


Requires
--------
gap-pkg-fplsa (rpmlib, GLIBC filtered):
    config(gap-pkg-fplsa)
    gap-core(x86-64)
    libc.so.6()(64bit)
    rtld(GNU_HASH)

gap-pkg-fplsa-doc (rpmlib, GLIBC filtered):
    gap-online-help
    gap-pkg-fplsa(x86-64)

gap-pkg-fplsa-debuginfo (rpmlib, GLIBC filtered):

gap-pkg-fplsa-debugsource (rpmlib, GLIBC filtered):



Provides
--------
gap-pkg-fplsa:
    config(gap-pkg-fplsa)
    gap-pkg-fplsa
    gap-pkg-fplsa(x86-64)

gap-pkg-fplsa-doc:
    gap-pkg-fplsa-doc
    gap-pkg-fplsa-doc(x86-64)

gap-pkg-fplsa-debuginfo:
    debuginfo(build-id)
    gap-pkg-fplsa-debuginfo
    gap-pkg-fplsa-debuginfo(x86-64)

gap-pkg-fplsa-debugsource:
    gap-pkg-fplsa-debugsource
    gap-pkg-fplsa-debugsource(x86-64)



----------------
PACKAGE APPROVED
----------------

Comment 6 Jerry James 2024-04-10 00:55:56 UTC

Thank you very much for the review, Matthieu!

Comment 7 Fedora Admin user for bugzilla script actions 2024-04-10 00:56:25 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/gap-pkg-fplsa

Comment 8 Fedora Update System 2024-04-10 01:56:27 UTC

FEDORA-2024-21cc3a6a62 (gap-pkg-fplsa-1.2.6-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-21cc3a6a62

Comment 9 Fedora Update System 2024-04-11 00:55:22 UTC

FEDORA-2024-21cc3a6a62 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-21cc3a6a62 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-21cc3a6a62

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2024-04-19 21:33:47 UTC

FEDORA-2024-21cc3a6a62 (gap-pkg-fplsa-1.2.6-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.