Bug 227090
| Summary: | Review Request: nekohtml-0.9.5-4jpp - HTML scanner and tag balancer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Rafael H. Schloming <rafaels> | ||||
| Component: | Package Review | Assignee: | Matt Wringe <mwringe> | ||||
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | klee, tross | ||||
| Target Milestone: | --- | Flags: | viveklak:
fedora-review+
petersen: fedora-cvs+ |
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2007-03-12 18:14:12 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Rafael H. Schloming
2007-02-02 17:48:05 UTC
Review comments:
* Apache-like license is not proper license name.
* license is not open source-compatible.
- use acronyms for licences where common
* correct buildroot
- should be:
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* rpmlint on <this package>.srpm gives some output
W: nekohtml non-standard-group Text Processing/Markup/HTML
W: nekohtml invalid-license Apache-like
E: nekohtml unknown-key GPG#c431416d
* changelog should be in one of these formats:
* Fri Jun 23 2006 Jesse Keating <jkeating> - 0.6-4
- And fix the link syntax.
* Fri Jun 23 2006 Jesse Keating <jkeating> 0.6-4
- And fix the link syntax.
* Fri Jun 23 2006 Jesse Keating <jkeating>
- 0.6-4
- And fix the link syntax.
* Vendor tag should not be used
* use macros appropriately and consistently
- ie. %{buildroot} and %{optflags} vs. $RPM_BUILD_ROOT and $RPM_OPT_FLAGS
* split Requires(pre,post) into two separate lines
Comments addressed. http://www.vermillionskye.com/downloads/nekohtml-0.9.5-4jpp.1.src.rpm http://www.vermillionskye.com/donwloads/nekohtml.spec Created attachment 148012 [details]
Small patch to spec file
Looks good overall, minor fixes to the spec file are attached in the patch. The
unversioned javadoc link is not necessary and it probably best to add a
requires/requires(postun) on jpackage-utils for %{_javadir}/%{_javadoc}
ownership
New patch applied. Removed requires postun as this was deemed unnecessary by
Andrew. I also put back the changelog entries I had changed as the old format
for e-mail address is ok. The %doc statement was changed to the new agreed
format of %{_javadocdir}/*
http://www.vermillionskye.com/downloads/nekohtml-0.9.5-4jpp.1.src.rpm
http://www.vermillionskye.com/downloads/nekohtml.spec
Looks good to me. Built fine in mock. I am going to approve this. Please build it into rawhide and once I can confirm it has made it through I will close it. New Package CVS Request ======================= Package Name: nekohtml Short Description: HTML scanner and tag balancer Owners: mwringe Branches: devel InitialCC: cvs module added |