Bug 2271125

Summary:	Review Request: rust-divan - Statistically-comfy benchmarking library
Product:	[Fedora] Fedora	Reporter:	Michel Lind <michel>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	decathorpe, package-review
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/divan
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-03-23 03:22:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2271123, 2271124
Bug Blocks:

Description Michel Lind 2024-03-22 20:56:02 UTC

Spec URL: https://salimma.fedorapeople.org/rust-divan.spec
SRPM URL: https://salimma.fedorapeople.org/rust-divan-0.1.14-1.fc39.src.rpm

Description:
Statistically-comfy benchmarking library.

Fedora Account System Username: salimma

Comment 1 Fedora Review Service 2024-03-22 20:58:36 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7202837
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271125-rust-divan/fedora-rawhide-x86_64/07202837-rust-divan/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2024-03-22 23:04:02 UTC

It appears that this is a benchmark-only dependency. The only code references in "nu" I can find to it are in "benches/benchmarks.rs".
I would recommend that you just remove the "divan" dev-dependency in the "nu" crate instead of packaging something that will end up unused.

Comment 3 Michel Lind 2024-03-23 03:22:13 UTC

Not actually needed, as Fabio noted. nu replaced criterion with this it seems