Bug 2271136
| Summary: | Touchpad not working on ThinkPad Z16 / hid-generic / hid-multitouch unbalanced collection at end of report description | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pär Eriksson <parherman> | ||||||
| Component: | kernel | Assignee: | Kernel Maintainer List <kernel-maint> | ||||||
| Status: | CLOSED COMPLETED | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | 40 | CC: | acaringi, adscvr, airlied, alciregi, bskeggs, diegossmiths, hdegoede, hpa, jarod, josef, kernel-maint, kevin.b.burns, linville, masami256, mchehab, me, mhayden, mpearson, ptalbert, steved | ||||||
| Target Milestone: | --- | Keywords: | Regression | ||||||
| Target Release: | --- | ||||||||
| Hardware: | x86_64 | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-05-17 07:02:56 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Pär Eriksson
2024-03-22 22:09:24 UTC
Created attachment 2023168 [details]
dmesg.txt
Also fails with latest Ubuntu 6.8.0 kernel Created attachment 2023434 [details]
dmesg.txt from 6.8.1-201.fc39.x86_64
I've reproduced on my Z13 G2 and am investigating. Looks like a kernel regression so far. Lenovo internal ticket is LO-2940 The Arch wiki has a section for the touchpad on the Z16/Z13 Gen (1/2) to fix the touchpad, but essentially doing: sudo rmmod i2c_hid_acpi sudo modprobe i2c_hid_acpi Hi Hans, I did a bisect on this and believe I've tracked it down to https://github.com/torvalds/linux/commit/af93a167eda90192563bce64c4bb989836afac1f I'll aim to do a bit more poking at this, but any pointers or suggestions? I'm not sure what the patch is actually fixing - so we might need to revert it until it's better understood? I can follow up with the touchpad vendor to do more debugging too Mark (In reply to Mark Pearson from comment #6) > Hi Hans, > I did a bisect on this and believe I've tracked it down to > https://github.com/torvalds/linux/commit/ > af93a167eda90192563bce64c4bb989836afac1f > I'll aim to do a bit more poking at this, but any pointers or suggestions? > I'm not sure what the patch is actually fixing - so we might need to revert > it until it's better understood? > I can follow up with the touchpad vendor to do more debugging too > Mark Mark, thank you for tracking this down and sorry for causing this regression. Another user has also noticed this and has already submitted a fix upstream: https://lore.kernel.org/linux-input/20240331182440.14477-1-kl@kl.wtf/T/#u I'll be reviewing this patch shortly. Thanks Hans! I'll look to test the patch and confirm on my system too. Mark Thorsten mentioned that the patch is mainlined now, but it missed the next 6.8.y release: https://fosstodon.org/@kernellogger/112332927888897951 Just an update, even while running any of the RC 6.9 kernels, I still have to use the fix suggested in the Arch wiki. Also, any kernel above RC4 ignores the hidraw haptic configurations. I just updated to 6.8.8-300.fc40.x86_64 on my Thinkpad Z13 G2 and rebooted -- touchpad works on boot! I didn't need any of the workarounds any longer. 🎉 Okay, disregard the last comment. After the third or fourth reboot, the issue came back and the touchpad does not work unless I use the workaround: sudo rmmod i2c_hid_acpi; sleep 5; sudo modprobe i2c_hid_acpi Still on 6.8.8-300 here. (In reply to Major Hayden 🤠 from comment #12) > Okay, disregard the last comment. After the third or fourth reboot, the > issue came back and the touchpad does not work unless I use the workaround: > > sudo rmmod i2c_hid_acpi; sleep 5; sudo modprobe i2c_hid_acpi > > Still on 6.8.8-300 here. Do the haptic settings work on the 6.8.8 kernel? (In reply to Major Hayden 🤠 from comment #12) > Okay, disregard the last comment. After the third or fourth reboot, the > issue came back and the touchpad does not work unless I use the workaround: > > sudo rmmod i2c_hid_acpi; sleep 5; sudo modprobe i2c_hid_acpi > > Still on 6.8.8-300 here. Thanks for the workaround, Major Hayden. Only with this, touchpad is working now. PS: kernel 6.8.8-300. Hmm - this either means you don't have the fix, or there is another problem. I really hope it's the first :( I checked the Fedora tree and the patch is in there: https://gitlab.com/cki-project/kernel-ark/-/commit/fb49deec375aa5beca4a5d71d7a74ec951872f28 - but it looks like it's only tagged for 6.8.9 (it was only committed to stable 3 days ago) I'll check on my systems to confirm, but I think you need to wait just a little bit longer for the fix to roll out I'm afraid. Mark (In reply to Kevin B. Burns from comment #13) > (In reply to Major Hayden 🤠 from comment #12) > > Okay, disregard the last comment. After the third or fourth reboot, the > > issue came back and the touchpad does not work unless I use the workaround: > > > > sudo rmmod i2c_hid_acpi; sleep 5; sudo modprobe i2c_hid_acpi > > > > Still on 6.8.8-300 here. > > Do the haptic settings work on the 6.8.8 kernel? With 6.8.8-300 I tested: hid-feature list /dev/hidraw0 hid-feature set /dev/hidraw0 -f b0000 100 hid-feature set /dev/hidraw0 -f b0000 50 hid-feature set /dev/hidraw0 -f b0000 0 and I could not feel any difference in haptic intensity. I have not tested this on previous kernels so I'm sure what it should feel like Fedora 6.8.9 kernel released is fixing this issue on my system - please let me know if you're still seeing problems. On the haptic settings - we've been discussing that with Sensel for a while now. I'll go and nag - but previously on the Z13/Z16 series we needed a special utility to get the configuration working. Possibly a dumbass question, but where did you get the hid-feature utility from? (In reply to Mark Pearson from comment #17) > Fedora 6.8.9 kernel released is fixing this issue on my system - please let > me know if you're still seeing problems. > > On the haptic settings - we've been discussing that with Sensel for a while > now. I'll go and nag - but previously on the Z13/Z16 series we needed a > special utility to get the configuration working. See if you have a Hidraw1 device. In the 6.9 kernel, I switched it from Hidraw0, to 1, and it works perfectly. Looks like the newer kernels are showing either the touchpad or the multi-point touch screen as a Wacom input interface. (In reply to Mark Pearson from comment #18) > Possibly a dumbass question, but where did you get the hid-feature utility > from? https://gitlab.freedesktop.org/libevdev/hid-tools.git/ I figured out the other day, for any of the 6.9 kernels, you need to use HiDraw1: sudo hid-feature set /dev/hidraw1 -f b0000 100 instead of sudo hid-feature set /dev/hidraw0 -f b0000 100 Nice :) Works for me too (P1 G7). Thanks! I was unaware of that utility. 6.8.9 is working fine on my Z13 Gen 2! 🎉 Sorry for my delay. My region is passing by for a flood. With the kernel version 6.8.9 my touchpad is working like a charm. It works for me too, I will close this bug as completed Thanks to everyone involved in fixing this! Hans, something similar is happening with 6.12-RC1. My Z16 Gen 2 touchpad stopped working again. This is on Fedora using the vanilla kernels Hi, Probably better to create a new bug to track thi, otherwise it gets confusing. I tried a 6.12-rc1 build from Linus's tree on my Z13 G2 (should be the same) and it's working fine. Can you share details of what exactly your kernel build was please? As a side note - I did see on Phoronix that the pixart touchpad got removed because it was causing problems in 6.12 (https://www.phoronix.com/news/Linux-6.12-Drops-PixArt-Driver). Bit of a long shot, but may be related? Suggest disabling or blacklisting that module maybe? Mark As mentioned in bug 2314756 there is an issue with the Fedora 6.12 kernel builds where the designware i2c-controller driver is not being build causing amongst other things touchpads to not work. I'm marking this as a duplicate of bug 2314756 and I'm working on a fix. *** This bug has been marked as a duplicate of bug 2314756 *** Oh wait, this really is another older bug, so marking it a dup was not the best idea. Let me mark this as normally closed again. Please add any further comments wrt the 6.12 touchpad issues to bug 2314756 . |