Bug 2271140
| Summary: | Review Request: gnome-online-accounts-gtk - GUI Utility for logging into online accounts | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | leigh scott <leigh123linux> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | joshua, miketwebster, ngompa13, package-review, williamjmorenor | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/linuxmint/%{name} | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-05-26 01:26:20 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
leigh scott
2024-03-22 23:50:46 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7203019 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271140-gnome-online-accounts-gtk/fedora-rawhide-x86_64/07203019-gnome-online-accounts-gtk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://leigh123linux.fedorapeople.org/pub/review/gnome-online-accounts-gtk/gnome-online-accounts-gtk.spec SRPM URL: https://leigh123linux.fedorapeople.org/pub/review/gnome-online-accounts-gtk/gnome-online-accounts-gtk-0.0.1-0.2.20240327git499a4d3.fc40.src.rpm Created attachment 2023919 [details]
The .spec file difference from Copr build 7203019 to 7223254
Copr build: https://copr.fedorainfracloud.org/coprs/build/7223254 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271140-gnome-online-accounts-gtk/fedora-rawhide-x86_64/07223254-gnome-online-accounts-gtk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://leigh123linux.fedorapeople.org/pub/review/gnome-online-accounts-gtk/gnome-online-accounts-gtk.spec SRPM URL: https://leigh123linux.fedorapeople.org/pub/review/gnome-online-accounts-gtk/gnome-online-accounts-gtk-3.50.1-1.fc40.src.rpm Created attachment 2023996 [details]
The .spec file difference from Copr build 7223254 to 7226330
Copr build: https://copr.fedorainfracloud.org/coprs/build/7226330 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271140-gnome-online-accounts-gtk/fedora-rawhide-x86_64/07226330-gnome-online-accounts-gtk/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://leigh123linux.fedorapeople.org/pub/review/gnome-online-accounts-gtk/gnome-online-accounts-gtk.spec SRPM URL: https://leigh123linux.fedorapeople.org/pub/review/gnome-online-accounts-gtk/gnome-online-accounts-gtk-3.50.2-1.fc40.src.rpm I was removed for the package review group, but I can confirm that the package works Review notes:
* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled and recorded
* No serious issues from rpmlint
Nit: Please replace "%url" with "%{url}" for consistency in Source0. Also, as you have a single source, you can just use "Source" instead if you wish.
PACKAGE APPROVED.
(In reply to Neal Gompa from comment #10) > Review notes: > > * Package follows Fedora Packaging Guidelines > * Package builds and installs > * Package licensing is correctly handled and recorded > * No serious issues from rpmlint > > Nit: Please replace "%url" with "%{url}" for consistency in Source0. Also, > as you have a single source, you can just use "Source" instead if you wish. > > PACKAGE APPROVED. Thank you for the review. The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-online-accounts-gtk FEDORA-2024-1b11b9675f (cinnamon-6.0.4-7.fc40 and gnome-online-accounts-gtk-3.50.2-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-1b11b9675f FEDORA-2024-1b11b9675f has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1b11b9675f` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1b11b9675f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-1b11b9675f (cinnamon-6.0.4-7.fc40 and gnome-online-accounts-gtk-3.50.2-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |