Bug 2271615
| Summary: | Review Request: redict - A persistent key-value database | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jonathan Wright <jonathan> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | ngompa13:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://redict.io | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-04-12 01:01:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Jonathan Wright
2024-03-26 14:32:47 UTC
Taking this review. Initial spec review: > %global macrosdir %(d=%{_rpmconfigdir}/macros.d; [ -d $d ] || d=%{_sysconfdir}/rpm; echo $d) This can be deleted and replaced with "%{_rpmmacrodir}" > Redict is an independent fork of Redis®* OSS 7.2.4 licensed under the > Lesser GNU General Public license (LGPL-3.0-only). > Redict is not affiliated with Redis®. This needs to be dropped from the description, it's unneeded and unwanted. > %{macrosdir}/* This needs to use "%{_rpmmacrodir}" and needs to be less greedy. > Source0: https://codeberg.org/redict/redict/archive/%{version}.tar.gz#/%{name}-%{version}.tar.gz
This needs to use "%{version_no_tilde}" or it won't resolve.
Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/redict/fedora-rawhide-ppc64le/07216791-redict/redict.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/redict/fedora-rawhide-ppc64le/07216791-redict/redict-7.3.0~rc1-2.fc41.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/7216757 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271615-redict/fedora-rawhide-x86_64/07216757-redict/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Created attachment 2023630 [details]
The .spec file difference from Copr build 7216757 to 7216803
Copr build: https://copr.fedorainfracloud.org/coprs/build/7216803 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271615-redict/fedora-rawhide-x86_64/07216803-redict/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/redict/fedora-rawhide-x86_64/07216889-redict/redict.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/redict/fedora-rawhide-x86_64/07216889-redict/redict-7.3.0~rc1-3.fc41.src.rpm Created attachment 2023632 [details]
The .spec file difference from Copr build 7216803 to 7216915
Copr build: https://copr.fedorainfracloud.org/coprs/build/7216915 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271615-redict/fedora-rawhide-x86_64/07216915-redict/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > %dir %{_sysconfdir}/systemd/system/%{name}.service.d
> %config(noreplace) %{_sysconfdir}/systemd/system/%{name}.service.d/limit.conf
> %dir %{_sysconfdir}/systemd/system/%{name}-sentinel.service.d
> %config(noreplace) %{_sysconfdir}/systemd/system/%{name}-sentinel.service.d/limit.conf
This needs to move from "%{_sysconfdir}/systemd/system" to "%{_unitdir}" and "%config(noreplace)" needs to be dropped.
The user may want to modify this file and there are notes in it as to why. Is this not acceptable? We did it in the KeyDB package. (In reply to Jonathan Wright from comment #12) > The user may want to modify this file and there are notes in it as to why. > Is this not acceptable? > > We did it in the KeyDB package. I didn't notice it there, or I would have pointed out it needs to be changed. For what it's worth, you can overshadow files in /usr with files in /etc. It will need to fixed in the other package too. Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/redict/fedora-40-aarch64/07220529-redict/redict.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/redict/fedora-40-aarch64/07220529-redict/redict-7.3.0~rc1-4.fc40.src.rpm > %{_sysconfdir}/sysconfig/%{name}
> %{_sysconfdir}/sysconfig/%{name}-sentinel
This should be "%config(noreplace)".
Created attachment 2023773 [details]
The .spec file difference from Copr build 7216915 to 7220618
Copr build: https://copr.fedorainfracloud.org/coprs/build/7220618 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271615-redict/fedora-rawhide-x86_64/07220618-redict/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/redict/fedora-rawhide-ppc64le/07221569-redict/redict.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/redict/fedora-rawhide-ppc64le/07221569-redict/redict-7.3.0~rc1-5.fc41.src.rpm Created attachment 2023839 [details]
The .spec file difference from Copr build 7220618 to 7221595
Copr build: https://copr.fedorainfracloud.org/coprs/build/7221595 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2271615-redict/fedora-rawhide-x86_64/07221595-redict/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > %exclude %{_rpmmacrodir}
> %exclude %{_includedir}
Non-blocking: Neither of these lines are needed, since these paths are exclusively already used in the devel subpackage. Please remove them on import.
(In reply to Neal Gompa from comment #21) > > %exclude %{_rpmmacrodir} > > %exclude %{_includedir} > > Non-blocking: Neither of these lines are needed, since these paths are > exclusively already used in the devel subpackage. Please remove them on > import. Will do. Just removed locally. Just some leftover cruft from the redis spec file which was my base. Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled and recorded * No serious issues from rpmlint PACKAGE APPROVED. The Pagure repository was created at https://src.fedoraproject.org/rpms/redict FEDORA-EPEL-2024-5e3399739d (redict-7.3.0~rc1-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-5e3399739d FEDORA-EPEL-2024-d9878ed2b4 (redict-7.3.0~rc1-1.el8) has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d9878ed2b4 FEDORA-2024-accfc0e13f (redict-7.3.0~rc1-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-accfc0e13f FEDORA-2024-e146da9479 (redict-7.3.0~rc1-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e146da9479 FEDORA-2024-0464e36f58 (redict-7.3.0~rc1-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-0464e36f58 FEDORA-2024-accfc0e13f has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-accfc0e13f \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-accfc0e13f See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-e146da9479 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e146da9479 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e146da9479 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-d9878ed2b4 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d9878ed2b4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-5e3399739d has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-5e3399739d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-0464e36f58 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0464e36f58 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0464e36f58 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-e5f9918238 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-e5f9918238` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-e5f9918238 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-41b96f27e8 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-41b96f27e8` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-41b96f27e8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-3c65f828c7 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-3c65f828c7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-a831275256 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-a831275256 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-6c9c62e827 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6c9c62e827` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6c9c62e827 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-1d2506e092 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-1d2506e092` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-1d2506e092 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-b4e517c75a has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b4e517c75a` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b4e517c75a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-6843ef573a has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-6843ef573a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-2792db8954 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-2792db8954 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-c9de0f01b8 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c9de0f01b8` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c9de0f01b8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-EPEL-2024-2792db8954 (redict-7.3.0-1.el8) has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-1d2506e092 (redict-7.3.0-1.fc38) has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-c9de0f01b8 (redict-7.3.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-EPEL-2024-6843ef573a (redict-7.3.0-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-b4e517c75a (redict-7.3.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |