Bug 2272133
| Summary: | Review Request: cosmic-settings-daemon - Settings daemon for the COSMIC desktop environment | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryan Brue <ryanbrue.dev> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | RELEASE_PENDING --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/pop-os/cosmic-settings-daemon | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2271980 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryan Brue
2024-03-29 01:14:10 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7229775 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272133-cosmic-settings-daemon/fedora-rawhide-x86_64/07229775-cosmic-settings-daemon/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338641-cosmic-settings-daemon/cosmic-settings-daemon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338641-cosmic-settings-daemon/cosmic-settings-daemon-0.1.0~git20240423.04.bf2e505-1.fc41.src.rpm Description: COSMIC settings daemon is used by COSMIC when changing certain settings, such as the icon theme. Fedora Account System Username: ryanabx Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377370-cosmic-settings-daemon/cosmic-settings-daemon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377370-cosmic-settings-daemon/cosmic-settings-daemon-0.1.0~git20240426.18.bf2e505-1.fc41.src.rpm Description: COSMIC settings daemon is used by COSMIC when changing certain settings, such as the icon theme. Fedora Account System Username: ryanabx Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004518-cosmic-settings-daemon/cosmic-settings-daemon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004518-cosmic-settings-daemon/cosmic-settings-daemon-0.1.0~%5E20240908gita41d199-1.fc42.src.rpm Description: COSMIC settings daemon is used by COSMIC when changing certain settings, such as the icon theme. Fedora Account System Username: ryanabx Created attachment 2046446 [details]
The .spec file difference from Copr build 7229775 to 8010434
Copr build: https://copr.fedorainfracloud.org/coprs/build/8010434 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272133-cosmic-settings-daemon/fedora-rawhide-x86_64/08010434-cosmic-settings-daemon/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085289-cosmic-settings-daemon/cosmic-settings-daemon.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085289-cosmic-settings-daemon/cosmic-settings-daemon-1.0.0~alpha.2-1.fc42.src.rpm Description: COSMIC settings daemon is used by COSMIC when changing certain settings, such as the icon theme. Fedora Account System Username: ryanabx Created attachment 2049230 [details]
The .spec file difference from Copr build 8010434 to 8086854
Copr build: https://copr.fedorainfracloud.org/coprs/build/8086854 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272133-cosmic-settings-daemon/fedora-rawhide-x86_64/08086854-cosmic-settings-daemon/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review.
✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines (using vendored crates for now)
Package APPROVED.
===
Extra notes:
- This is somewhat dependent on cosmic-comp at runtime (for display configuration), so it should be declared as a runtime dependency ("Requires: cosmic-comp >= %{version}"). Please add it.
===
Recommended post-import tasks:
- set up package on release-monitoring.org:
- add @rust-sig with "commit" access as package co-maintainer
(should happen automatically)
- add @cosmic-sig with "admin" access as package co-maintainer
- set bugzilla assignee overrides to @cosmic-sig
- track package in koschei for all built branches
(should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-settings-daemon |