Bug 2272136
| Summary: | Review Request: pop-launcher - Flexible backend for launcher-type applications | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryan Brue <ryanbrue.dev> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | RELEASE_PENDING --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/pop-os/launcher | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 2271980, 2272137 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryan Brue
2024-03-29 01:52:35 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7231026 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272136-pop-launcher/fedora-rawhide-x86_64/07231026-pop-launcher/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338640-pop-launcher/pop-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338640-pop-launcher/pop-launcher-1.2.1~git20240423.04.a7fc5bc-1.fc41.src.rpm Description: pop-launcher is a backend for launcher applications. It is used with cosmic-launcher for the COSMIC desktop environment Fedora Account System Username: ryanabx Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377369-pop-launcher/pop-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377369-pop-launcher/pop-launcher-1.2.1~git20240426.18.a7fc5bc-1.fc41.src.rpm Description: pop-launcher is a backend for launcher applications. It is used with cosmic-launcher for the COSMIC desktop environment Fedora Account System Username: ryanabx Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004521-pop-launcher/pop-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004521-pop-launcher/pop-launcher-0.1.0~%5E20240814git6a1b8b9-1.fc42.src.rpm Description: pop-launcher is a backend for launcher applications. It is used with cosmic-launcher for the COSMIC desktop environment Fedora Account System Username: ryanabx Created attachment 2046443 [details]
The .spec file difference from Copr build 7231026 to 8010436
Copr build: https://copr.fedorainfracloud.org/coprs/build/8010436 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272136-pop-launcher/fedora-rawhide-x86_64/08010436-pop-launcher/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression '(Apache-2.0 OR MIT) AND BSD-3-Clause AND Apache-2.0 AND Apache-2.0 OR BSL-1.0 AND Apache-2.0 OR ISC OR MIT AND Apache-2.0 OR MIT AND Apache-2.0 WITH LLVM-exception AND Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT AND BSD-3-Clause AND GPL-3.0 AND GPL-3.0-only AND ISC AND MIT AND MIT OR Apache-2.0 AND MIT OR Apache-2.0 OR BSD-2-Clause AND MIT OR Apache-2.0 OR Zlib AND MPL-2.0 AND MPL-2.0 OR MIT OR Apache-2.0 AND Unlicense OR MIT AND Zlib AND Zlib OR Apache-2.0 OR MIT'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085291-pop-launcher/pop-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085291-pop-launcher/pop-launcher-1.2.3%5Egit20240814.6a1b8b9-1.fc42.src.rpm Description: pop-launcher is a backend for launcher applications. It is used with cosmic-launcher for the COSMIC desktop environment Fedora Account System Username: ryanabx Created attachment 2049223 [details]
The .spec file difference from Copr build 8010436 to 8086859
Copr build: https://copr.fedorainfracloud.org/coprs/build/8086859 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272136-pop-launcher/fedora-rawhide-x86_64/08086859-pop-launcher/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Initial review notes:
> %dir %{_prefix}/lib/pop-launcher
> %{_prefix}/lib/pop-launcher/*
These look like binaries rather than libraries, so they should be installing into "%{_libexecdir}/pop-launcher/" (ie. /usr/libexec/pop-launcher).
(In reply to Neal Gompa from comment #11) > Initial review notes: > > > %dir %{_prefix}/lib/pop-launcher > > %{_prefix}/lib/pop-launcher/* > > These look like binaries rather than libraries, so they should be installing > into "%{_libexecdir}/pop-launcher/" (ie. /usr/libexec/pop-launcher). Note that this may require code adjustments to make it read that location. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08090937-pop-launcher/pop-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08090937-pop-launcher/pop-launcher-1.2.3%5Egit20240814.6a1b8b9-1.fc42.src.rpm Description: pop-launcher is a backend for launcher applications. It is used with cosmic-launcher for the COSMIC desktop environment Fedora Account System Username: ryanabx Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines (using vendored crates for now) Package APPROVED. === Recommended post-import tasks: - set up package on release-monitoring.org: - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - add @cosmic-sig with "admin" access as package co-maintainer - set bugzilla assignee overrides to @cosmic-sig - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/pop-launcher |