Bug 2272137
| Summary: | Review Request: cosmic-launcher - pop-launcher frontend for COSMIC | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryan Brue <ryanbrue.dev> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | RELEASE_PENDING --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/pop-os/cosmic-launcher | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 2272136 | ||||||||
| Bug Blocks: | 2271980 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryan Brue
2024-03-29 01:54:36 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7231027 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272137-cosmic-launcher/fedora-rawhide-x86_64/07231027-cosmic-launcher/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression 'GPL-3.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338633-cosmic-launcher/cosmic-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338633-cosmic-launcher/cosmic-launcher-0.1.0~git20240423.04.f6b9df7-1.fc41.src.rpm Description: cosmic-launcher is a frontend for pop-launcher and is used in COSMIC. Note: depends on pop-launcher, which is also being reviewed. Fedora Account System Username: ryanabx Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377362-cosmic-launcher/cosmic-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377362-cosmic-launcher/cosmic-launcher-0.1.0~git20240426.18.fa94de7-1.fc41.src.rpm Description: cosmic-launcher is a frontend for pop-launcher and is used in COSMIC. Note: depends on pop-launcher, which is also being reviewed. Fedora Account System Username: ryanabx Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004513-cosmic-launcher/cosmic-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004513-cosmic-launcher/cosmic-launcher-0.1.0~%5E20240909git9269534-1.fc42.src.rpm Description: cosmic-launcher is a frontend for pop-launcher and is used in COSMIC. Note: depends on pop-launcher, which is also being reviewed. Fedora Account System Username: ryanabx Created attachment 2046448 [details]
The .spec file difference from Copr build 7231027 to 8010438
Copr build: https://copr.fedorainfracloud.org/coprs/build/8010438 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272137-cosmic-launcher/fedora-rawhide-x86_64/08010438-cosmic-launcher/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression '0BSD OR MIT OR Apache-2.0 AND Apache-2.0 AND Apache-2.0 OR BSL-1.0 AND Apache-2.0 OR MIT AND Apache-2.0 WITH LLVM-exception AND Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT AND BSD-2-Clause AND BSD-3-Clause AND BSL-1.0 AND CC0-1.0 AND GPL-3.0 AND ISC AND MIT AND MIT AND BSD-3-Clause AND MIT OR Apache-2.0 AND MIT OR Apache-2.0 OR CC0-1.0 AND MIT OR Apache-2.0 OR Zlib AND MIT OR Zlib OR Apache-2.0 AND MPL-2.0 AND Unlicense OR MIT AND Zlib AND Zlib OR Apache-2.0 OR MIT'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085284-cosmic-launcher/cosmic-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085284-cosmic-launcher/cosmic-launcher-1.0.0~alpha.2-1.fc42.src.rpm Description: cosmic-launcher is a frontend for pop-launcher and is used in COSMIC. Note: depends on pop-launcher, which is also being reviewed. Fedora Account System Username: ryanabx Created attachment 2049229 [details]
The .spec file difference from Copr build 8010438 to 8086875
Copr build: https://copr.fedorainfracloud.org/coprs/build/8086875 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272137-cosmic-launcher/fedora-rawhide-x86_64/08086875-cosmic-launcher/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Taking this review. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08091024-cosmic-launcher/cosmic-launcher.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08091024-cosmic-launcher/cosmic-launcher-1.0.0~alpha.2-1.fc42.src.rpm Description: cosmic-launcher is a frontend for pop-launcher and is used in COSMIC. Note: depends on pop-launcher, which is also being reviewed. Fedora Account System Username: ryanabx Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines (using vendored crates for now) Package APPROVED. === Recommended post-import tasks: - set up package on release-monitoring.org: - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - add @cosmic-sig with "admin" access as package co-maintainer - set bugzilla assignee overrides to @cosmic-sig - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-launcher |