Bug 2272138
| Summary: | Review Request: cosmic-notifications - Notifications daemon for COSMIC | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ryan Brue <ryanbrue.dev> | ||||||
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> | ||||||
| Status: | RELEASE_PENDING --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | ngompa13, package-review | ||||||
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| URL: | https://github.com/pop-os/cosmic-notifications | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | Type: | --- | |||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | 2272134 | ||||||||
| Bug Blocks: | 2271980 | ||||||||
| Attachments: |
|
||||||||
|
Description
Ryan Brue
2024-03-29 01:56:24 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7231028 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272138-cosmic-notifications/fedora-rawhide-x86_64/07231028-cosmic-notifications/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression 'GPL-3.0'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338634-cosmic-notifications/cosmic-notifications.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07338634-cosmic-notifications/cosmic-notifications-0.1.0~git20240423.04.4ea0564-1.fc41.src.rpm Description: cosmic-notifications is the notifications daemon for COSMIC, which helps collect notifications and send them to the proper applications. Fedora Account System Username: ryanabx Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377363-cosmic-notifications/cosmic-notifications.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/07377363-cosmic-notifications/cosmic-notifications-0.1.0~git20240426.18.4ea0564-1.fc41.src.rpm Description: cosmic-notifications is the notifications daemon for COSMIC, which helps collect notifications and send them to the proper applications. Fedora Account System Username: ryanabx Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004514-cosmic-notifications/cosmic-notifications.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch/fedora-rawhide-x86_64/08004514-cosmic-notifications/cosmic-notifications-0.1.0~%5E20240801gite9abef5-1.fc42.src.rpm Description: cosmic-notifications is the notifications daemon for COSMIC, which helps collect notifications and send them to the proper applications. Fedora Account System Username: ryanabx Created attachment 2046447 [details]
The .spec file difference from Copr build 7231028 to 8010439
Copr build: https://copr.fedorainfracloud.org/coprs/build/8010439 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272138-cosmic-notifications/fedora-rawhide-x86_64/08010439-cosmic-notifications/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Not a valid SPDX expression '0BSD OR MIT OR Apache-2.0 AND Apache-2.0 AND Apache-2.0 OR BSD-3-Clause AND Apache-2.0 OR BSL-1.0 AND Apache-2.0 OR MIT AND Apache-2.0 WITH LLVM-exception OR Apache-2.0 OR MIT AND BSD-2-Clause AND BSD-3-Clause AND BSL-1.0 AND CC0-1.0 AND GPL-3.0 AND ISC AND MIT AND MIT AND BSD-3-Clause AND MIT OR Apache-2.0 AND MIT OR Apache-2.0 OR CC0-1.0 AND MIT OR Apache-2.0 OR Zlib AND MIT OR Zlib OR Apache-2.0 AND MPL-2.0 AND Unlicense OR MIT AND Zlib AND Zlib OR Apache-2.0 OR MIT'. Read more: https://fedoraproject.org/wiki/Changes/SPDX_Licenses_Phase_1 Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Spec URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085285-cosmic-notifications/cosmic-notifications.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/ryanabx/cosmic-epoch-tagged/fedora-rawhide-x86_64/08085285-cosmic-notifications/cosmic-notifications-1.0.0~alpha.2-1.fc42.src.rpm Description: cosmic-notifications is the notifications daemon for COSMIC, which helps collect notifications and send them to the proper applications. Fedora Account System Username: ryanabx Created attachment 2049225 [details]
The .spec file difference from Copr build 8010439 to 8086877
Copr build: https://copr.fedorainfracloud.org/coprs/build/8086877 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2272138-cosmic-notifications/fedora-rawhide-x86_64/08086877-cosmic-notifications/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines (using vendored crates for now) Package APPROVED. === Extra notes: - This is dependent on xdg-desktop-portal at runtime, please add "Requires: xdg-desktop-portal" on import. === Recommended post-import tasks: - set up package on release-monitoring.org: - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - add @cosmic-sig with "admin" access as package co-maintainer - set bugzilla assignee overrides to @cosmic-sig - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) (In reply to Neal Gompa from comment #10) > === > > Extra notes: > > - This is dependent on xdg-desktop-portal at runtime, please add "Requires: > xdg-desktop-portal" on import. > Ignore this, my clipboard went screwy. The Pagure repository was created at https://src.fedoraproject.org/rpms/cosmic-notifications |