Bug 2272927
| Summary: | libsecret: One COPYING shadows the other in /usr/share/licenses/libsecret-devel/COPYING | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | libsecret | Assignee: | Debarshi Ray <debarshir> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | debarshir, dueno, gnome-sig, klember, stefw |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libsecret-0.21.7-7.fc43 libsecret-0.21.7-4.fc42 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-11-06 02:43:24 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Miro Hrončok
2024-04-03 10:05:02 UTC
Looks like this is a regression from commit https://src.fedoraproject.org/rpms/libsecret/c/1107d4a0c098b6b2c6345c484cb4be8e79a976dd I guess there are a few ways to solve this, but the simplest is probably to just drop the "COPYING" file from libsecret-devel and only ship "docs/reference/COPYING". The first "COPYING" file is already included in the base libsecret package (which libsecret-devel requires) and I don't think there is any need to install it again as part of the -devel package. I concur with your conclusion that the first "COPYING" file does not need to be there. However, the docs/reference/COPYING file does not apply to the entire devel package, so including just that as "COPYING" seems confusing. Does the package even ship other files from docs/reference? If not, perhaps this COPYING file should not be shipped at all -- and the devel package should not include either of the files... ? This bug appears to have been reported against 'rawhide' during the Fedora Linux 42 development cycle. Changing version to 42. Recently, the following change was done: %files devel -%license COPYING docs/reference/COPYING +%license COPYING ... as part of this commit: https://src.fedoraproject.org/rpms/libsecret/c/ed7ef7e6d4ae1b12c55fd979170e95178ca28bab Together with this commit: https://src.fedoraproject.org/rpms/libsecret/c/afc97c7fcf58dafdf05805b15e2d615d92ff0e19 ... I see that the top-level COPYING file is now shipped by libsecret, libsecret-devel and libsecret-mock-service. I don't know if that's a good or bad thing, but it seemed at least vaguely relevant here. :) (In reply to Miro Hrončok from comment #2) > I concur with your conclusion that the first "COPYING" file does not need to > be there. > > However, the docs/reference/COPYING file does not apply to the entire devel > package, so including just that as "COPYING" seems confusing. > > Does the package even ship other files from docs/reference? If not, perhaps > this COPYING file should not be shipped at all -- and the devel package > should not include either of the files... ? Yes, the libsecret-devel subpackage does ship the content from docs/reference, because that's the reference API documentation for libsecret. Almost all libraries in the GNOME platform do something similar. This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component. This package has changed maintainer in Fedora. Reassigning to the new maintainer of this component. We should also update the License tag to include docs/reference/COPYING (ie., GCR-docs). FEDORA-2025-04cb513f17 (libsecret-0.21.7-7.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-04cb513f17 FEDORA-2025-04cb513f17 has been pushed to the Fedora 43 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-04cb513f17` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-04cb513f17 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-7998c8fb4c (libsecret-0.21.7-4.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2025-7998c8fb4c FEDORA-2025-04cb513f17 (libsecret-0.21.7-7.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2025-7998c8fb4c has been pushed to the Fedora 42 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-7998c8fb4c` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-7998c8fb4c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2025-7998c8fb4c (libsecret-0.21.7-4.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report. |