Bug 2273337
| Summary: | jrnl fails to build with pytest 8: Tests are failing with pytest 8.1 | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tomáš Hrnčiar <thrnciar> |
| Component: | jrnl | Assignee: | Ben Beasley <code> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | code, mhroncok, thrnciar |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | jrnl-4.1-9.fc41 jrnl-4.1-11.fc41 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-07-30 15:21:39 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2256331 | ||
|
Description
Tomáš Hrnčiar
2024-04-04 09:37:21 UTC
================= 243 failed, 396 passed, 40 skipped in 6.12s ================== Upstream is aware, https://github.com/jrnl-org/jrnl/issues/1879, but does not yet have a fix. I’m willing to skip the (very many) affected tests or temporarily disable the tests if upstream doesn’t come up with something before you are otherwise ready to ship pytest 8. I think we can wait for the upstream's reaction. I don't plan to ship pytest 8 in the immediate future. There are plenty of packages that still need to be fixed and I don't want to disrupt Python 3.13 effort. Unless they are miraculously fixed quickly I'd like to ship pytest after Python 3.13 mass rebuild in June/July. @code I'd like to ship pytest 8 soon and it seems like there is no progress regarding this issue in the upstream. We can either use pytest 8 and skip the failing tests or use the python-pytest7 compat package for now. What do you prefer? Is there a COPR that I can use to try jrnl with pytest 8, so I can see exactly which tests are failing in Fedora? It doesn’t seem like https://copr.fedorainfracloud.org/coprs/thrnciar/pytest/ is current. Assuming there are still 243 failing tests on pytest 8, and a python-pytest7 compat package is already planned, then I would be inclined to use the compat package for now so that I have good test coverage and an early warning about any compatibility issues with *other* updates. If, in the future, there are fewer packages depending on pytest 7 and jrnl starts standing in the way of retiring the compat package, then I would reconsider. Hopefully upstream will figure out the right fix before that happens. Yeah, there are still 243 failing tests. You can use this COPR for testing: https://copr.fedorainfracloud.org/coprs/thrnciar/pytest-8.3.1/ Currently, we have 10 packages that will need compat package (including jrnl). (In reply to Tomáš Hrnčiar from comment #6) > Yeah, there are still 243 failing tests. You can use this COPR for testing: > https://copr.fedorainfracloud.org/coprs/thrnciar/pytest-8.3.1/ > Currently, we have 10 packages that will need compat package (including > jrnl). Thanks, that’s very helpful. I investigated whether this was due to https://github.com/pytest-dev/pytest-bdd/issues/689, but applying https://github.com/pytest-dev/pytest-bdd/pull/690 as a downstream patch to python-pytest-bdd didn’t seem to make any difference. I’ll open a PR on jrnl to use the python-pytest7 compat package for now. It’s really awkward to skip just the failing tests, because they have names like test_create_entry_using_day_of_the_week_as_entry_date_one[sunday: entry on a sunday-entry on a sunday-2019-03-10 09:00] that create quoting and escaping difficulties, and if I skip just the base names of the failing tests, e.g. test_create_entry_using_day_of_the_week_as_entry_date_one above, then I end up disabling *all* of the tests. So if this isn’t fixed in the next few months and jrnl ends up being one of the last users of the compat package, I’ll just end up disabling the tests and doing %pyproject_check_import only. I followed up upstream in https://github.com/jrnl-org/jrnl/issues/1879#issuecomment-2258379926. FEDORA-2024-e9ec653813 (jrnl-4.1-9.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-e9ec653813 FEDORA-2024-e9ec653813 (jrnl-4.1-9.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. Thank you for the help! FEDORA-2024-9912bd663b (jrnl-4.1-11.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-9912bd663b FEDORA-2024-9912bd663b (jrnl-4.1-11.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |