Bug 2273566

Summary: python-atpublic fails to build with pytest 8: TypeError: FixtureManager.getfixtureclosure() missing 1 required positional argument: 'ignore_args'
Product: [Fedora] Fedora Reporter: Tomáš Hrnčiar <thrnciar>
Component: python-atpublicAssignee: Aurelien Bompard <aurelien>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: aurelien, epel-packagers-sig, jonathan, mhroncok, thrnciar
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-04-22 12:27:55 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2256331    

Description Tomáš Hrnčiar 2024-04-05 08:15:45 UTC
python-atpublic fails to build with pytest 8.

==================================== ERRORS ====================================
_______________________ ERROR collecting docs/using.rst ________________________
/usr/lib/python3.12/site-packages/sybil/integration/pytest.py:49: in __init__
    self.request_fixtures(sybil.fixtures)
/usr/lib/python3.12/site-packages/sybil/integration/pytest.py:54: in request_fixtures
    closure = fm.getfixtureclosure(names, self)
E   TypeError: FixtureManager.getfixtureclosure() missing 1 required positional argument: 'ignore_args'

During handling of the above exception, another exception occurred:
/usr/lib/python3.12/site-packages/sybil/integration/pytest.py:118: in collect
    yield SybilItem.from_parent(self, sybil=self.sybil, example=example)
/usr/lib/python3.12/site-packages/_pytest/nodes.py:237: in from_parent
    return cls._create(parent=parent, **kw)
/usr/lib/python3.12/site-packages/_pytest/nodes.py:129: in _create
    return super().__call__(*k, **known_kw)  # type: ignore[no-any-return,misc]
/usr/lib/python3.12/site-packages/sybil/integration/pytest.py:49: in __init__
    self.request_fixtures(sybil.fixtures)
/usr/lib/python3.12/site-packages/sybil/integration/pytest.py:54: in request_fixtures
    closure = fm.getfixtureclosure(names, self)
E   TypeError: FixtureManager.getfixtureclosure() missing 1 required positional argument: 'ignore_args'
=============================== warnings summary ===============================
../../../../usr/lib/python3.12/site-packages/sybil/document.py:3
  /usr/lib/python3.12/site-packages/sybil/document.py:3: DeprecationWarning: ast.Str is deprecated and will be removed in Python 3.14; use ast.Constant instead
    from ast import AsyncFunctionDef, FunctionDef, ClassDef, Module, Expr, Str, Constant

../../../../usr/lib/python3.12/site-packages/_pytest/nodes.py:120
  /usr/lib/python3.12/site-packages/_pytest/nodes.py:120: PytestDeprecationWarning: <class 'sybil.integration.pytest.SybilItem'> is not using a cooperative constructor and only takes {'sybil', 'example', 'parent'}.
  See https://docs.pytest.org/en/stable/deprecations.html#constructors-of-custom-pytest-node-subclasses-should-take-kwargs for more details.
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
ERROR docs/using.rst - TypeError: FixtureManager.getfixtureclosure() missing ...
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!
========================= 2 warnings, 1 error in 0.07s =========================

I'm getting the same error also with the latest released version 4.1.0.
https://docs.pytest.org/en/stable/changelog.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/thrnciar/pytest/fedora-rawhide-x86_64/07247756-python-atpublic/

For all our attempts to build python-atpublic with pytest 8, see:
https://copr.fedorainfracloud.org/coprs/thrnciar/pytest/package/python-atpublic/

Let us know here if you have any questions.

Pytest 8 is planned to be included in Fedora 41. And this bugzilla is a
heads up before we merge new pytest into rawhide. For more info see a Fedora Change
proposal https://fedoraproject.org/wiki/Changes/Pytest_8

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Tomáš Hrnčiar 2024-04-22 12:27:55 UTC
Closing, the latest version builds with pytest 8.