Bug 2274357

Summary: Review Request: tree-sitter-dockerfile - Dockerfile grammar for Tree-sitter
Product: [Fedora] Fedora Reporter: Peter Oliver <mavit>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: NEW --- QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: loganjerry, package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard: BuildFails NotReady
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2258924    

Description Peter Oliver 2024-04-10 14:47:37 UTC
Spec URL: https://mavit.fedorapeople.org/rpm/tree-sitter-dockerfile.spec
SRPM URL: https://mavit.fedorapeople.org/rpm/tree-sitter-dockerfile-0.1.2%5e20231010git33e22c33bc-1.20240410git33e22c3.fc41.src.rpm
Description: Dockerfile grammar for Tree-sitter
Fedora Account System Username: mavit

Comment 1 Package Review 2025-04-11 00:45:19 UTC
This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time. We're sorry
it is taking so long. If you're still interested in packaging this software
into Fedora repositories, please respond to this comment clearing the
NEEDINFO flag.

You may want to update the specfile and the src.rpm to the latest version
available and to propose a review swap on Fedora devel mailing list to increase
chances to have your package reviewed. If this is your first package and you
need a sponsor, you may want to post some informal reviews. Read more at
https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group.

Without any reply, this request will shortly be considered abandoned
and will be closed.
Thank you for your patience.

Comment 3 Fedora Review Service 2025-04-11 11:53:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8890995
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2274357-tree-sitter-dockerfile/fedora-rawhide-x86_64/08890995-tree-sitter-dockerfile/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Jerry James 2025-06-09 15:55:55 UTC
Fedora-review reports a build error in %conf:

+ cd tree-sitter-dockerfile-0.2.0
+ tree-sitter init
IO error: not a terminal
Caused by:
    not a terminal
error: Bad exit status from /var/tmp/rpm-tmp.dR1vyQ (%conf)
    Bad exit status from /var/tmp/rpm-tmp.dR1vyQ (%conf)

Comment 5 Peter Oliver 2025-06-12 11:50:58 UTC
My workaround for https://github.com/camdencheek/tree-sitter-dockerfile/issues/48 stopped working with tree-sitter-cli 0.25.  

We could come up with a patch instead, but I'm minded not to introduce to Fedora a new package which seems like it may already be abandoned upstream.