Bug 2274359
| Summary: | Review Request: klevernotes - A convergent markdown note taking application | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Steve Cossette <farchord> | ||||||
| Component: | Package Review | Assignee: | Yaakov Selkowitz <yselkowi> | ||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | marcdeop, package-review, yselkowi | ||||||
| Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
| Target Release: | --- | Flags: | yselkowi:
fedora-review+
|
||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| URL: | https://apps.kde.org/klevernotes/ | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2024-11-26 14:42:48 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Steve Cossette
2024-04-10 14:56:26 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/klevernotes/klevernotes.spec SRPM URL: https://farchord.fedorapeople.org/reviews/klevernotes/klevernotes-1.1.0-1.fc41.src.rpm Updated to release version 1.1.0 [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/8169440 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2274359-klevernotes/fedora-rawhide-x86_64/08169440-klevernotes/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. A few points: * Is anything actually under the CC-BY-SA-4.0 license? * QML import dependencies need to be added as Requires * I'd move the Requires: hicolor-icon-theme after all the BuildRequires for readability. * %files should include %doc README.md * The changelog entry needs to be updated. Spec URL: https://farchord.fedorapeople.org/reviews/klevernotes/klevernotes.spec SRPM URL: https://farchord.fedorapeople.org/reviews/klevernotes/klevernotes-1.1.0-1.fc41.src.rpm Updated with suggestions Created attachment 2059774 [details]
The .spec file difference from Copr build 8169440 to 8312523
Copr build: https://copr.fedorainfracloud.org/coprs/build/8312523 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2274359-klevernotes/fedora-rawhide-x86_64/08312523-klevernotes/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. > BuildRequires: cmake(Qt6WebEngineWidgets) This isn't used, only Qt6WebEngineQuick (already listed). > BuildRequires: cmake(KF6Kirigami2) That name is deprecated and not used; this should be KF6Kirigami instead. > Requires: qt6qml(org.kde.kirigamiaddons) This one is incorrect, each of the Kirigami Addons are their own import, as you can see from their provides (e.g. https://koji.fedoraproject.org/koji/rpminfo?rpmID=40754617). Listing all that are used may be an overkill though, but at least one of them needs to be. Spec URL: https://farchord.fedorapeople.org/reviews/klevernotes/klevernotes.spec SRPM URL: https://farchord.fedorapeople.org/reviews/klevernotes/klevernotes-1.1.0-1.fc41.src.rpm Updated with suggestions Created attachment 2059776 [details]
The .spec file difference from Copr build 8312523 to 8312632
Copr build: https://copr.fedorainfracloud.org/coprs/build/8312632 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2274359-klevernotes/fedora-rawhide-x86_64/08312632-klevernotes/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. LGTM, approved. Thank you for the review, Yaakov The Pagure repository was created at https://src.fedoraproject.org/rpms/klevernotes |