Bug 2274364

Summary: cannot find glslang with find_package(glslang REQUIRED) for glslang 14.1.0
Product: [Fedora] Fedora Reporter: Felix Wang <topazus>
Component: glslangAssignee: José Expósito <jexposit>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: rawhideCC: airlied, ajax, epel-packagers-sig, jexposit
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: glslang-14.1.0-2.fc40 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-04-11 09:13:33 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Felix Wang 2024-04-10 15:26:47 UTC
```
❯ cat CMakeLists.txt
cmake_minimum_required(VERSION 3.24)

project(
  test
  VERSION "1.0.0"
  LANGUAGES CXX C
)
find_package(glslang REQUIRED)

ruby in 🌐 fedora in ~/fedora-src/cmake-test via △ v3.28.3
❯ rm -rf build/ && cmake . -B build/
-- The CXX compiler identification is GNU 14.0.1
-- The C compiler identification is GNU 14.0.1
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/lib64/ccache/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/lib64/ccache/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
CMake Error at /usr/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package):
  By not providing "FindSPIRV-Tools-opt.cmake" in CMAKE_MODULE_PATH this
  project has asked CMake to find a package configuration file provided by
  "SPIRV-Tools-opt", but CMake did not find one.

  Could not find a package configuration file provided by "SPIRV-Tools-opt"
  with any of the following names:

    SPIRV-Tools-optConfig.cmake
    spirv-tools-opt-config.cmake

  Add the installation prefix of "SPIRV-Tools-opt" to CMAKE_PREFIX_PATH or
  set "SPIRV-Tools-opt_DIR" to a directory containing one of the above files.
  If "SPIRV-Tools-opt" provides a separate development package or SDK, be
  sure it has been installed.
Call Stack (most recent call first):
  /usr/lib64/cmake/glslang/glslang-config.cmake:38 (find_dependency)
  CMakeLists.txt:8 (find_package)


-- Configuring incomplete, errors occurred!

ruby in 🌐 fedora in ~/fedora-src/cmake-test via △ v3.28.3
❯ rpm -q glslang-devel
glslang-devel-14.1.0-1.fc41.x86_64
```

Reproducible: Always

Comment 1 José Expósito 2024-04-11 08:15:15 UTC
Installing spirv-tools should address it:


    $ sudo dnf install spirv-tools spirv-tools-devel


But I think that in Fedora 39 installing "glslang-devel" was enough for your makefile to work. I'll investigate what changed. Thanks for reporting it!

Comment 2 José Expósito 2024-04-11 08:57:49 UTC
It should be fixed (on Fedora Rawhide) by this build. I'd appreciate if you could test the generated package:
- https://bodhi.fedoraproject.org/updates/FEDORA-2024-1e1ba77ca8
- https://koji.fedoraproject.org/koji/taskinfo?taskID=116212940

Comment 3 Felix Wang 2024-04-11 09:13:33 UTC
Thanks for the response. It works now. Closing.

Comment 4 Fedora Update System 2024-04-11 09:21:00 UTC
FEDORA-2024-d90821a498 (glslang-14.1.0-2.fc40, shaderc-2024.0-1.fc40, and 8 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-d90821a498

Comment 5 Fedora Update System 2024-04-12 02:04:27 UTC
FEDORA-2024-d90821a498 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d90821a498`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d90821a498

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-04-19 21:28:25 UTC
FEDORA-2024-d90821a498 (glslang-14.1.0-2.fc40, shaderc-2024.0-1.fc40, and 8 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.