Bug 2274746
Summary: | Review Request: libschrift- lightweight TrueType font rendering C library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Manish Tiwari <matiwari> |
Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | package-review, panemade |
Target Milestone: | --- | Flags: | panemade:
fedora-review?
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | If docs needed, set a value | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | Type: | --- | |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | |||
Bug Blocks: | 177841 |
Description
Manish Tiwari
2024-04-12 16:42:09 UTC
It appears you need sponsorship to become Fedora package maintainer. Get familiar with below information https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/ https://docs.fedoraproject.org/en-US/package-maintainers/Packaging_Tutorial_GNU_Hello/ Below is initial review of just SPEC file inspection and rpmlint output Issues: ======= - Header files in -devel subpackage, if present. Note: libschrift : /usr/include/schrift.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===> Read https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: libschrift. Illegal package name: libschrift. Does not provide -static: libschrift. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#packaging-static-libraries ==> This package need to be fixed to generate dynamic library and not static library. - You don't need to write below line in SPEC ExclusiveArch: x86_64 aarch64 ppc64le s390x Package should be building on all arch unless known for specific reason - %description text should be aligned to 80 characters per line - You should write actual version and release values and not macros * Mon Mar 25 2024 Manish Tiwari <matiwari> - %{version}-%{release} change to * Mon Mar 25 2024 Manish Tiwari <matiwari> - 0.10.2-1 - Package must own all directories that it creates. Note: Directories without known owners: /usr/share/man, /usr/include, /usr/share/doc, /usr/share/licenses, /usr/share, /usr/lib, /usr ==> Your package should own the directories in which this package is installing files. Rpmlint ------- Checking: libschrift-0.10.2-1.fc41.x86_64.rpm libschrift-0.10.2-1.fc41.src.rpm ============================ rpmlint session starts ============================ libschrift.x86_64: E: static-library-without-debuginfo /usr/lib/libschrift.a libschrift.x86_64: E: standard-dir-owned-by-package /usr/share/man/man3 libschrift.spec:9: W: mixed-use-of-spaces-and-tabs (spaces: line 5, tab: line 9) libschrift.spec:49: W: macro-in-%changelog %{version} libschrift.spec:49: W: macro-in-%changelog %{release} libschrift.x86_64: W: devel-file-in-non-devel-package /usr/include/schrift.h libschrift.x86_64: W: devel-file-in-non-devel-package /usr/lib/libschrift.a libschrift.src: E: description-line-too-long libschrift is a lightweight TrueType font rendering library that provides basic font rendering capabilities. It aims for simplicity and efficiency, making it suitable for various embedded and resource-constrained environments. libschrift.x86_64: E: description-line-too-long libschrift is a lightweight TrueType font rendering library that provides basic font rendering capabilities. It aims for simplicity and efficiency, making it suitable for various embedded and resource-constrained environments. 2 packages and 0 specfiles checked; 4 errors, 5 warnings, 9 filtered, 4 badness; has taken 0.2 s Fix above issues and submit new SRPM and SPEC by updating release to 2 and adding changelog about changes done in SPEC file Any update here Manish? Can you also start doing un-official package reviews of other contributor's submissions? Check that list https://fedoraproject.org/PackageReviewStatus/reviewable.html |