Bug 2275097

Summary:	bridge_name is not translated to br-ex in osp 17.1 (ffu from 16.2)
Product:	Red Hat OpenStack	Reporter:	Shailesh Chhabdiya <schhabdi>
Component:	documentation	Assignee:	kgilliga
Status:	CLOSED CURRENTRELEASE	QA Contact:	RHOS Documentation Team <rhos-docs>
Severity:	high	Docs Contact:
Priority:	high
Version:	17.1 (Wallaby)	CC:	abhijadh, astupnik, bshephar, hjensas, jbadiapa, jkreger, jpretori, kgilliga, mariel, mflusche, parthee, ravsingh, sbaker
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-05-31 19:34:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Shailesh Chhabdiya 2024-04-15 11:42:22 UTC

Description of problem:
 bridge_name is not translated to br-ex in osp 17.1 (ffu from 16.2)
Upgrade goes well but if any stack update is ran post FFU the nic-config templates still containes `bridge_name`

  name: bridge_name
  type: ovs_bridge
  use_dhcp: false 

Version-Release number of selected component (if applicable):
RHOSP17.1 [FFU]

How reproducible:
Always 


Actual results:
The template remain incorrect which can cause outage

Expected results:
The template should be rendered completely

Additional info:

Comment 2 Brendan Shephard 2024-04-16 04:11:04 UTC

We don't use bridge_name in any of our example templates, but I can see the user has tried using the tool to convert their Heat templates into the new Jinja2 ones (https://github.com/openstack-archive/tripleo-heat-templates/blob/stable/wallaby/tools/convert_heat_nic_config_to_ansible_j2.py) and it hasn't updated the bridge_name to the correct Ansible variable. That can probably be fixed in the tool, adding in HardProv to assess that part.

For example, in the multiple_nics.j2 file, it has the correct Ansible variable for the bridge name:
https://github.com/openstack-archive/tripleo-ansible/blob/stable/wallaby/tripleo_ansible/roles/tripleo_network_config/templates/multiple_nics/multiple_nics.j2#L25

So for the user in this case, the nic-configs can be updated with the correct Ansible variable as per the sample file above. That should resolve any issues they were having there.