Bug 2275484

Summary: Rook operator is hardcoded to use redhat catalog, even when installing ODF from a custom catalog
Product: [Red Hat Storage] Red Hat OpenShift Data Foundation Reporter: RY <ryasharz>
Component: odf-operatorAssignee: Nitin Goyal <nigoyal>
Status: CLOSED ERRATA QA Contact: Coady LaCroix <clacroix>
Severity: high Docs Contact:
Priority: unspecified    
Version: 4.16CC: dollierp, muagarwa, nberry, nigoyal, odf-bz-bot
Target Milestone: ---Keywords: Regression
Target Release: ODF 4.16.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-17 13:19:44 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description RY 2024-04-17 11:59:33 UTC 
Description of problem (please be detailed as possible and provide log
snippests):

When adding ODF custom catalog with any image above 4.16.0-39
installation ODF can't finish as the rook operator is stuck
as it try to install itself from `RedHat Catalog` even when ODF was installed 
from the custom catalog.



Version of all relevant components (if applicable):

  Any catalog image above 4.16.0-39


Is there any workaround available to the best of your knowledge?

  For now we are pined to 4.16.0-39

Rate from 1 - 5 the complexity of the scenario you performed that caused this
bug (1 - very simple, 5 - very complex)?

   1 - very simple

Can this issue reproducible?

   Yes


Can this issue reproduce from the UI?

   Yes


If this is a regression, please provide more details to justify this:

   Yes


Steps to Reproduce:
1. Add a new Catalog with image pointing to the latest dev like 
   quay.io/rhceph-dev/ocs-registry:latest-stable-4.16
2. Try to install ODF 


Actual results:

   Rook operator will not be installed, as it source will point to redhat operator's catalog


Expected results:


Additional info:
Comment 3 Nitin Goyal 2024-04-17 12:15:58 UTC 
In the current version 4.16, the odf-operator doesn't include Rook as a dependency to allow upgrades from 4.15. This is because the new odf tries to bring Rook, but conflicts arise with the existing ocs-operator 4.15 which has all rook components. This problem causes upgrade attempts to fail. This was the reason for removing the rook as a dependency from the odf-operator. But the odf-operator was bringing it via creating the subscription while recociling. But it does not work well when we use a custom catalog source.

To make it work with the custom catalog source we will have to add rook as a dependency in the ocs-operator.

Boris can you pls add rook as a dependency in the ocs-operator bundle in the DS?
Comment 7 Denis Ollier 2024-04-22 07:23:23 UTC 
Verified with build 4.16.0-82.
Comment 10 Coady LaCroix 2024-05-23 17:27:48 UTC 
Verified with build 4.16.0-108
Comment 11 errata-xmlrpc 2024-07-17 13:19:44 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.16.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:4591