Bug 2276031

Summary: Namespace add command output interprets wrong load balancing group number though it assigns correctly
Product: [Red Hat Storage] Red Hat Ceph Storage Reporter: Rahul Lepakshi <rlepaksh>
Component: NVMeOFAssignee: Gil Bregman <gbregman>
Status: CLOSED ERRATA QA Contact: Rahul Lepakshi <rlepaksh>
Severity: medium Docs Contact: Akash Raj <akraj>
Priority: unspecified    
Version: 7.1CC: acaro, akraj, cephqe-warriors, gbregman, tserlin
Target Milestone: ---Flags: rlepaksh: needinfo-
Target Release: 7.1   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ceph-nvmeof-container-1.2.5-3 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-13 14:31:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2267614, 2298578, 2298579    

Description Rahul Lepakshi 2024-04-19 06:19:03 UTC
Description of problem:
Namespace add command output interprets wrong load balancing group number though it assigns correctly

# nvmeof namespace add -n nqn.2016-06.io.spdk:cnode1 -p rbd -i demo_image1
Adding namespace 1 to nqn.2016-06.io.spdk:cnode1, load balancing group 0: Successful  ---> LB group 0 does not exist

# nvmeof namespace add -n nqn.2016-06.io.spdk:cnode1 -p rbd -i demo_image2
Adding namespace 2 to nqn.2016-06.io.spdk:cnode1, load balancing group 0: Successful  ---> LB group 0 does not exist

# nvmeof namespace list -n nqn.2016-06.io.spdk:cnode1
Namespaces in subsystem nqn.2016-06.io.spdk:cnode1:
╒════════╤════════════════════════╤════════╤═════════════╤═════════╤═════════╤═════════════════════╤═════════════╤═══════════╤═══════════╤════════════╤═════════════╕
│   NSID │ Bdev                   │ RBD    │ RBD         │ Image   │ Block   │ UUID                │        Load │ R/W IOs   │ R/W MBs   │ Read MBs   │ Write MBs   │
│        │ Name                   │ Pool   │ Image       │ Size    │ Size    │                     │   Balancing │ per       │ per       │ per        │ per         │
│        │                        │        │             │         │         │                     │       Group │ second    │ second    │ second     │ second      │
╞════════╪════════════════════════╪════════╪═════════════╪═════════╪═════════╪═════════════════════╪═════════════╪═══════════╪═══════════╪════════════╪═════════════╡
│      1 │ bdev_7d4dd1e7-a989-    │ rbd    │ demo_image1 │ 20 GiB  │ 512 B   │ 7d4dd1e7-a989-499b- │           1 │ unlimited │ unlimited │ unlimited  │ unlimited   │
│        │ 499b-9048-86b647711782 │        │             │         │         │ 9048-86b647711782   │             │           │           │            │             │
├────────┼────────────────────────┼────────┼─────────────┼─────────┼─────────┼─────────────────────┼─────────────┼───────────┼───────────┼────────────┼─────────────┤
│      2 │ bdev_99254aa6-1da9-    │ rbd    │ demo_image2 │ 20 GiB  │ 512 B   │ 99254aa6-1da9-48c3- │           2 │ unlimited │ unlimited │ unlimited  │ unlimited   │
│        │ 48c3-85a6-28422a47a859 │        │             │         │         │ 85a6-28422a47a859   │             │           │           │            │             │
├────────┼────────────────────────┼────────┼─────────────┼─────────┼─────────┼─────────────────────┼─────────────┼───────────┼───────────┼────────────┼─────────────┤
│      3 │ bdev_48e12c11-7388-    │ rbd    │ demo_image6 │ 20 GiB  │ 512 B   │ 48e12c11-7388-47c4- │           1 │ unlimited │ unlimited │ unlimited  │ unlimited   │
│        │ 47c4-a19e-1698703e7706 │        │             │         │         │ a19e-1698703e7706   │             │           │           │            │             │
├────────┼────────────────────────┼────────┼─────────────┼─────────┼─────────┼─────────────────────┼─────────────┼───────────┼───────────┼────────────┼─────────────┤
│      4 │ bdev_d3c34ee7-6e39-    │ rbd    │ demo_image7 │ 20 GiB  │ 512 B   │ d3c34ee7-6e39-47ee- │           2 │ unlimited │ unlimited │ unlimited  │ unlimited   │
│        │ 47ee-bc59-8848d734cfcd │        │             │         │         │ bc59-8848d734cfcd   │             │           │           │            │             │
╘════════╧════════════════════════╧════════╧═════════════╧═════════╧═════════╧═════════════════════╧═════════════╧═══════════╧═══════════╧════════════╧═════════════╛
# ceph nvme-gw show nvmeof_pool ''
{
    "pool": "nvmeof_pool",
    "group": "",
    "num gws": 2,
    "Anagrp list": "[ 1 2 ]"
}
{
    "gw-id": "client.nvmeof.nvmeof_pool.ceph-ibm-ha-v2-jv6bpi-node4.lglviq",
    "anagrp-id": 1,
    "last-gw_map-epoch-valid": 1,
    "Availability": "AVAILABLE",
    "ana states": " 1: ACTIVE , 2: STANDBY ,"
}
{
    "gw-id": "client.nvmeof.nvmeof_pool.ceph-ibm-ha-v2-jv6bpi-node5.waxbdr",
    "anagrp-id": 2,
    "last-gw_map-epoch-valid": 1,
    "Availability": "AVAILABLE",
    "ana states": " 1: STANDBY , 2: ACTIVE ,"
}


Version-Release number of selected component (if applicable):
# ceph version
ceph version 18.2.1-149.el9cp (6944266a2186e8940baeefc45140e9c798b90141) reef (stable)

  cp.stg.icr.io/cp/ibm-ceph/nvmeof-cli-rhel9:1.2.4-1
  cp.stg.icr.io/cp/ibm-ceph/nvmeof-rhel9:1.2.4-1

How reproducible: always 


Steps to Reproduce:
1.Add namespace to a subsystem 
2.Output mentions wrong LB group number
3.

Actual results: Output mentions wrong LB group number


Expected results: We should list correct LB group number 


Additional info:

Comment 1 Gil Bregman 2024-04-19 21:04:15 UTC
@rlepaksh this is not a real problem. The CLI just displays the parameter passed to it not the actual group id. Now that we have automatic assignment of a group id this information is mostly useless. We should either remove this from the CLI or make sure we return the real group id from the gateway.

Comment 2 Aviv Caro 2024-04-21 16:50:38 UTC
This is fixed in downstream, and will be provided as a part of next downstream build that will be numbered 1.2.5.

Comment 7 Rahul Lepakshi 2024-05-08 04:50:41 UTC
Verified with http://magna002.ceph.redhat.com/cephci-jenkins/cephci-run-QH78M3/

Running command podman run --rm cp.stg.icr.io/cp/ibm-ceph/nvmeof-cli-rhel9:1.2.6-1  --server-address 10.0.210.105 --server-port 5500 namespace add  --rbd-image 89V5-image4 --rbd-pool rbd --subsystem nqn.2016-06.io.spdk:cnode1 on 10.0.210.105 timeout 600
2024-05-08 00:12:01,603 (cephci.test_ceph_nvmeof_gateway_sub_scale) [INFO] - cephci.ceph.ceph.py:1597 - Command completed successfully
2024-05-08 00:12:01,604 (cephci.test_ceph_nvmeof_gateway_sub_scale) [INFO] - cephci.ceph.nvmegw_cli.execute.py:54 - ('', 'Adding namespace 4 to nqn.2016-06.io.spdk:cnode1: Successful\n')

Comment 9 Gil Bregman 2024-05-09 11:57:16 UTC
@akraj why did you flag me for more info? Isn't this issue already closed?

Comment 11 errata-xmlrpc 2024-06-13 14:31:49 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Critical: Red Hat Ceph Storage 7.1 security, enhancements, and bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:3925