Bug 2276055

Summary:	Sync provider mode specific changes from main to 4.16
Product:	[Red Hat Storage] Red Hat OpenShift Data Foundation	Reporter:	Leela Venkaiah Gangavarapu <lgangava>
Component:	ocs-operator	Assignee:	Mudit Agarwal <muagarwa>
Status:	CLOSED ERRATA	QA Contact:	Jilju Joy <jijoy>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.16	CC:	muagarwa, nberry, nigoyal, odf-bz-bot, sapillai
Target Milestone:	---
Target Release:	ODF 4.16.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	isf-provider
Fixed In Version:	4.16.0-84	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-07-17 13:19:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Leela Venkaiah Gangavarapu 2024-04-19 12:49:34 UTC

On main, we have below changes that need to be synced to release-4.16 branch, pls note these aren't features however renames, scope changes and resulting internal refactor.

1. StorageClient is moved from NamespaceScope to ClusterScope
2. StorageClassRequests is renamed to StorageRequests and the type field in the spec now takes either `sharedfile` or `block` as the valid values (non user facing)
3. Force cleanup of StorageConsumer which was initially marked as exception will be in
4. UI can now have the ability to find the connected cluster name

Features which are already in 4.16 branch doesn't support upgrade (just reiterating) and as such builds containing above should be freshly deployed.

Probably the only change in CI test suite that I anticipate is removal of `Namespace` field from StorageClient CR if you are onboarding external clients.

Comment 7 Jilju Joy 2024-05-03 11:28:18 UTC

Hi Leela,

Please describe the steps to verify the points 3 and 4 given in the description.

Comment 9 Santosh Pillai 2024-05-15 17:40:57 UTC

try below commands to start with 

For RadosNamespace:
- Ensure no images are available in the cephblockpool rados namespace. 
  - rbd ls -l <pool-name>  --namespace <namespace>


For SubvolumeGroup
- Ensure no subvolumes are available in the SubvolumeGroup
   - ceph fs subvolume ls <fsname>

Comment 10 Santosh Pillai 2024-05-17 06:52:25 UTC

(In reply to Santosh Pillai from comment #9)
> try below commands to start with 
> 
> For RadosNamespace:
> - Ensure no images are available in the cephblockpool rados namespace. 
>   - rbd ls -l <pool-name>  --namespace <namespace>
> 
> 
> For SubvolumeGroup
> - Ensure no subvolumes are available in the SubvolumeGroup
>    - ceph fs subvolume ls <fsname>

Correction: 

ceph fs subvolume ls <fsname> <subvolumeGroup>

Comment 11 Jilju Joy 2024-05-17 10:04:13 UTC

Verified the points 1 and 2 given in the description.

1. Storageclient is now ClusterScoped.

% oc get crd storageclients.ocs.openshift.io -o jsonpath={.spec.scope}
Cluster

% oc get storageclient -A
NAME                          PHASE       CONSUMER
ocs-storagecluster            Connected   10c6cd39-eeab-4a8e-afb3-cf7de76ffb44
storage-client-provider-bm3   Connected   6bd682bc-b987-475b-a6a7-97f021c11273

2.
StorageClassRequests is renamed to StorageRequests

% oc get StorageClassRequests                              
error: the server doesn't have a resource type "StorageClassRequests"

% oc get StorageRequests 
NAME                                              STORAGETYPE   PHASE
storagerequest-c23ea2444eb6e591ba5a6423620c5f4d   block         Ready
storagerequest-c6622a08a297712136c4fe8fd39e878c   sharedfile    Ready

Type field in the spec of storagerequest is either `sharedfile` or `block`.

% oc get StorageRequests  -o yaml
apiVersion: v1
items:
- apiVersion: ocs.openshift.io/v1alpha1
  kind: StorageRequest
  metadata:
    creationTimestamp: "2024-04-30T05:35:57Z"
    finalizers:
    - ocs.openshift.io.storagerequest
    generation: 1
    labels:
      ocs.openshift.io/storageconsumer-uuid: 10c6cd39-eeab-4a8e-afb3-cf7de76ffb44
      ocs.openshift.io/storagerequest-name: ocs-storagecluster-ceph-rbd
    name: storagerequest-c23ea2444eb6e591ba5a6423620c5f4d
    namespace: openshift-storage
    ownerReferences:
    - apiVersion: ocs.openshift.io/v1alpha1
      blockOwnerDeletion: true
      kind: StorageConsumer
      name: storageconsumer-4f974f42-2301-460a-90a5-2607cabea062
      uid: 10c6cd39-eeab-4a8e-afb3-cf7de76ffb44
    resourceVersion: "35748901"
    uid: 036c63d0-c086-478c-9f05-7da7203338b3
  spec:
    type: block
  status:
    cephResources:
    - kind: CephClient
      name: aac7982cf5289b0dac095c6e2af926c9
      status: Ready
    - kind: CephClient
      name: 3411165c412a6113e839724c52bbdbf4
      status: Ready
    - cephClients:
        node: 3411165c412a6113e839724c52bbdbf4
        provisioner: aac7982cf5289b0dac095c6e2af926c9
      kind: CephBlockPoolRadosNamespace
      name: cephradosnamespace-93c9c5371e85ff9aff654a2c52793168
      status: Ready
    phase: Ready
- apiVersion: ocs.openshift.io/v1alpha1
  kind: StorageRequest
  metadata:
    creationTimestamp: "2024-04-30T05:35:57Z"
    finalizers:
    - ocs.openshift.io.storagerequest
    generation: 1
    labels:
      ocs.openshift.io/storageconsumer-uuid: 10c6cd39-eeab-4a8e-afb3-cf7de76ffb44
      ocs.openshift.io/storagerequest-name: ocs-storagecluster-cephfs
    name: storagerequest-c6622a08a297712136c4fe8fd39e878c
    namespace: openshift-storage
    ownerReferences:
    - apiVersion: ocs.openshift.io/v1alpha1
      blockOwnerDeletion: true
      kind: StorageConsumer
      name: storageconsumer-4f974f42-2301-460a-90a5-2607cabea062
      uid: 10c6cd39-eeab-4a8e-afb3-cf7de76ffb44
    resourceVersion: "35748813"
    uid: 452623e1-bb1b-4b09-97c3-fb0398d6ee0f
  spec:
    type: sharedfile
  status:
    cephResources:
    - kind: CephClient
      name: 37611cfdb4e2369369444095f4a7df10
      status: Ready
    - kind: CephClient
      name: d1ff6b867d9d558fe31b8437c339b422
      status: Ready
    - cephClients:
        node: d1ff6b867d9d558fe31b8437c339b422
        provisioner: 37611cfdb4e2369369444095f4a7df10
      kind: CephFilesystemSubVolumeGroup
      name: cephfilesystemsubvolumegroup-37cc21ae05c0a784309eaa59847d0b30
      status: Ready
    phase: Ready
kind: List
metadata:
  resourceVersion: ""


The point 3 given in the description is tested and failed. 2 new bugs were created to track it. 
https://bugzilla.redhat.com/show_bug.cgi?id=2280813
https://bugzilla.redhat.com/show_bug.cgi?id=2280946

Not blocking the verification of this bug. The two bugs will be verified separately.  


The point 4 given in the description is verified in the bug https://bugzilla.redhat.com/show_bug.cgi?id=2262975. There is another bug raised for a part of fix that needs to be done to completely enable point 4 given in the description of this bug. It is tracked in https://bugzilla.redhat.com/show_bug.cgi?id=2278593.

Hence , moving this bug to verified state.

Verified in version:
% oc get clusterversion
NAME      VERSION       AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0-ec.5   True        False         16d     Cluster version is 4.16.0-ec.5

% oc get csv
NAME                                        DISPLAY                            VERSION            REPLACES                                    PHASE
mcg-operator.v4.16.0-96.stable              NooBaa Operator                    4.16.0-96.stable   mcg-operator.v4.16.0-92.stable              Succeeded
ocs-client-operator.v4.16.0-96.stable       OpenShift Data Foundation Client   4.16.0-96.stable   ocs-client-operator.v4.16.0-92.stable       Succeeded
ocs-operator.v4.16.0-96.stable              OpenShift Container Storage        4.16.0-96.stable   ocs-operator.v4.16.0-92.stable              Succeeded
odf-csi-addons-operator.v4.16.0-96.stable   CSI Addons                         4.16.0-96.stable   odf-csi-addons-operator.v4.16.0-92.stable   Succeeded
odf-operator.v4.16.0-96.stable              OpenShift Data Foundation          4.16.0-96.stable   odf-operator.v4.16.0-92.stable              Succeeded
odf-prometheus-operator.v4.16.0-96.stable   Prometheus Operator                4.16.0-96.stable   odf-prometheus-operator.v4.16.0-92.stable   Succeeded
recipe.v4.16.0-96.stable                    Recipe                             4.16.0-96.stable                                               Succeeded
rook-ceph-operator.v4.16.0-96.stable        Rook-Ceph                          4.16.0-96.stable   rook-ceph-operator.v4.16.0-92.stable        Succeeded

Cluster is on IBM cloud BM.

Comment 12 errata-xmlrpc 2024-07-17 13:19:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat OpenShift Data Foundation 4.16.0 security, enhancement & bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2024:4591