Bug 2276265

Summary: right click doesn't work
Product: [Fedora] Fedora Reporter: Han Boetes <hboetes>
Component: terminatorAssignee: Dominic Hopf <dmaphy>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 40CC: dmaphy, mattrose
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: terminator-2.1.4-1.fc40.1 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-20 01:51:18 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Han Boetes 2024-04-21 09:33:07 UTC
If you open a terminator in a terminator and then right click the new terminator window, you are greeted with this error message.

han@it1notebook ~ %  /usr/bin/terminator 
/usr/lib/python3.12/site-packages/terminatorlib/plugins/command_notify.py:26: Warning: invalid (NULL) pointer instance
  Vte.Terminal().connect('notification-received',lambda *args: None,None)
/usr/lib/python3.12/site-packages/terminatorlib/plugins/command_notify.py:26: Warning: g_signal_handlers_disconnect_matched: assertion 'G_TYPE_CHECK_INSTANCE (instance)' failed
  Vte.Terminal().connect('notification-received',lambda *args: None,None)
Traceback (most recent call last):
  File "/usr/lib/python3.12/site-packages/terminatorlib/terminal.py", line 1031, in on_buttonpress
    right_click[0](*right_click[1])
  File "/usr/lib/python3.12/site-packages/terminatorlib/terminal.py", line 1077, in popup_menu
    menu.show(widget, event)
  File "/usr/lib/python3.12/site-packages/terminatorlib/terminal_popup_menu.py", line 169, in show
    item = self.menu_item(Gtk.ImageMenuItem, 'edit_window_title',
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/terminatorlib/terminal_popup_menu.py", line 55, in menu_item
    mask    = self.get_menu_item_mask(maskstr)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib/python3.12/site-packages/terminatorlib/terminal_popup_menu.py", line 33, in get_menu_item_mask
    maskstr = maskstr.lower()
              ^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'lower'


I tried building from github and with that version the problem does not occur.

Reproducible: Always

Comment 1 Fedora Update System 2024-06-18 02:53:20 UTC
FEDORA-2024-5006d68fb6 (terminator-2.1.4-1.fc40.1) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-5006d68fb6

Comment 2 Fedora Update System 2024-06-19 02:05:30 UTC
FEDORA-2024-5006d68fb6 has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-5006d68fb6`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-5006d68fb6

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 3 Fedora Update System 2024-06-20 01:51:18 UTC
FEDORA-2024-5006d68fb6 (terminator-2.1.4-1.fc40.1) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.