Bug 2276356

There are few minor changes required.

> Provides:       golang-github-elves-elvish = %{version}-%{release}

I'm not sure if this is required with the obsolote in place should propose already the change to this new package.


Build reports this warning:

RPM build warnings:
    File listed twice: /usr/share/licenses/elvish/LICENSE
    File listed twice: /usr/share/licenses/elvish/LICENSE
    File listed twice: /usr/share/licenses/elvish/LICENSE
    File listed twice: /usr/share/licenses/elvish/LICENSE
    File listed twice: /usr/share/licenses/elvish/LICENSE


Check on https://download.copr.fedorainfracloud.org/results/mikelo2/elvish/fedora-rawhide-x86_64/07333485-elvish/elvish.spec how LICENSE files are renamed to be able to install all.

1. I see this in https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages

quote:
> If a package is being renamed without any functional changes, or is a compatible-enough replacement to an existing package (where "enough" means that it includes only > changes of magnitude that are commonly found in version upgrade changes), provide clean upgrade paths and compatibility with:
>
> Provides: oldpackagename = $provEVR
> Obsoletes: oldpackagename < $obsEVR

2.
> RPM build warnings:
>     File listed twice: /usr/share/licenses/elvish/LICENSE
>     File listed twice: /usr/share/licenses/elvish/LICENSE
>     File listed twice: /usr/share/licenses/elvish/LICENSE
>     File listed twice: /usr/share/licenses/elvish/LICENSE
>     File listed twice: /usr/share/licenses/elvish/LICENSE
>
>
> Check on https://download.copr.fedorainfracloud.org/results/mikelo2/elvish/fedora-rawhide-x86_64/07333485-elvish/elvish.spec how LICENSE files are renamed to be able to install all.

adopted the rename change to resolve this issue in the spec file.

---

Spec URL: https://topazus.fedorapeople.org/elvish.spec
SRPM URL: https://topazus.fedorapeople.org/elvish-0.20.1-1.fc39.src.rpm

The review.txt showed an error, https://download.copr.fedorainfracloud.org/results/topazus/test-review/fedora-rawhide-x86_64/07335299-elvish/fedora-review/review.txt

elvish.x86_64: E: readelf-failed /usr/bin/elvish 'utf-8' codec can't decode byte 0xc2 in position 7599: invalid continuation byte

The upstream maintainer said it may be related to specific setting of Fedora building, https://github.com/elves/elvish/issues/1793

Do you have thoughts on dealing with this?

> elvish.x86_64: E: readelf-failed /usr/bin/elvish 'utf-8' codec can't decode byte 0xc2 in position 7599: invalid continuation byte

I would say it's an issue on rpmlint. I would try to report it upstream rpmlint https://github.com/rpm-software-management/rpmlint/

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [x] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [x] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Thanks for the reviewing.

The Pagure repository was created at https://src.fedoraproject.org/rpms/elvish

FEDORA-2024-6a19ed65eb (elvish-0.20.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6a19ed65eb

FEDORA-2024-6a19ed65eb (elvish-0.20.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.