Bug 2276414
| Summary: | Review Request: perl-Call-Context - Sanity-check calling context | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peter Oliver <mavit> | ||||
| Component: | Package Review | Assignee: | Jitka Plesnikova <jplesnik> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | rawhide | CC: | jplesnik, package-review | ||||
| Target Milestone: | --- | Flags: | jplesnik:
fedora-review+
|
||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| URL: | https://metacpan.org/dist/Call-Context | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2024-10-10 00:16:41 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 2276416 | ||||||
| Attachments: |
|
||||||
|
Description
Peter Oliver
2024-04-22 13:29:03 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. ERROR: 'Error HTTP Error 404: Not Found downloading https://download.copr.fedorainfracloud.org/results/mavit/perlimports/fedora-rawhide-x86_64/07396234-perl-Call-Context/perl-Call-Context-0.05-1.fc41.src.rpm' Please provide the source rpm. Copr build: https://copr.fedorainfracloud.org/coprs/build/8091872 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2276414-perl-call-context/fedora-rawhide-x86_64/08091872-perl-Call-Context/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok
BuildRequires
FIX: Add build-requires
coreutils it is needed for %{_fixperms}
perl(strict) - lib/Call/Context.pm:78
perl(warnings) - lib/Call/Context.pm:79
If you don't want to add it to EPEL 7, please consider fixing
these 'TODO' items:
TODO: Add "NO_PACKLIST=1 NO_PERLLOCAL=1" to 'perl Makefile.PL'
If you use option NO_PACKLIST=1, please add version constrain
to ExtUtils::MakeMaker >= 6.76
Remove "find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;".
TODO: Use %{make_install} instead of "make pure_install".
TODO: Remove "find $RPM_BUILD_ROOT -depth -type d -exec rmdir {} 2>/dev/null ';'"
It's not needed.
$ rpm -qp --requires perl-Call-Context-0.05-1.fc42.noarch.rpm | sort | uniq -c | grep -v rpmlib
1 perl-libs
1 perl(strict)
1 perl(warnings)
Binary requires are Ok.
$ rpm -qp --provides perl-Call-Context-0.05-1.fc42.noarch.rpm | sort | uniq -c
1 perl(Call::Context) = 0.05
1 perl-Call-Context = 0.05-1.fc42
1 perl(Call::Context::X)
Binary provides are Ok.
Rpmlint is ok
TODO: The package does not contain directory %{perl_vendorarch}/auto/, you
can remove '%exclude %dir %{perl_vendorarch}/auto/'
TODO: Explicitly name packaged files in %{_mandir}/man* and %{perl_vendorlib} directories
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_explicit_lists.
Otherwise the package is in line with Fedora and Perl packaging guide lines.
Please correct all 'FIX' items, consider fixing 'TODO' items and provide a new spec file.
Resolution:
NOT Approved
Thanks for the review. All items fixed. SRPM URL: https://download.copr.fedorainfracloud.org/results/mavit/perlimports/fedora-rawhide-aarch64/08092163-perl-Call-Context/perl-Call-Context-0.05-1.fc42.src.rpm Created attachment 2049552 [details]
The .spec file difference from Copr build 8091872 to 8092172
Copr build: https://copr.fedorainfracloud.org/coprs/build/8092172 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2276414-perl-call-context/fedora-rawhide-x86_64/08092172-perl-Call-Context/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. It looks good now. Resolution: Approved The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Call-Context FEDORA-2024-b1eb8e4308 (perl-Call-Context-0.05-6.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b1eb8e4308 FEDORA-2024-b63605368a (perl-Call-Context-0.05-6.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b63605368a FEDORA-2024-99d9369dc4 (perl-Call-Context-0.05-6.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-99d9369dc4 FEDORA-2024-b63605368a has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b63605368a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b63605368a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-b1eb8e4308 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b1eb8e4308 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b1eb8e4308 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-99d9369dc4 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-99d9369dc4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-99d9369dc4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates. FEDORA-2024-b1eb8e4308 (perl-Call-Context-0.05-6.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-99d9369dc4 (perl-Call-Context-0.05-6.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2024-b63605368a (perl-Call-Context-0.05-6.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report. |