Bug 2277185

Summary: Review Request: rust-reqwest-retry - Retry middleware for reqwest
Product: [Fedora] Fedora Reporter: Ben Beasley <code>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Flags: decathorpe: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-05-21 15:26:11 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2276949, 2276959    
Bug Blocks:    
Attachments:
Description Flags
Configuration file for rust2rpm none

Description Ben Beasley 2024-04-25 15:30:24 UTC
Spec URL: https://music.fedorapeople.org/rust-reqwest-retry.spec
SRPM URL: https://music.fedorapeople.org/rust-reqwest-retry-0.5.0-1.fc39.src.rpm

Description:

Retry middleware for reqwest.

Fedora Account System Username: music

This is a dependency for a future package of https://pypi.org/project/uv.

The following were hand-edited from the output of rust2rpm:

- Replaced "# FIXME: no license files detected" with "%license LICENSE-APACHE LICENSE-MIT"

Comment 1 Ben Beasley 2024-04-25 15:31:34 UTC
Created attachment 2029183 [details]
Configuration file for rust2rpm

Comment 2 Ben Beasley 2024-04-25 17:02:54 UTC
As noted in https://bugzilla.redhat.com/show_bug.cgi?id=2276949#c9,

%license LICENSE-APACHE LICENSE-MIT

would be better written as

%license %{crate_instdir}/LICENSE-APACHE
%license %{crate_instdir}/LICENSE-MIT

If no other issues are found, I’ll adjust that detail on import.

Comment 3 Ben Beasley 2024-04-25 17:03:17 UTC
https://release-monitoring.org/project/372148/

Comment 4 Fabio Valentini 2024-05-20 20:38:57 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
! test suite is run and all unit tests pass (disabled with explanation)
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license files are included with %license in %files
  (included manually from upstream + PR to include them in published crates was accepted)
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 5 Ben Beasley 2024-05-21 14:12:30 UTC
Thank you for the review!

Comment 6 Fedora Admin user for bugzilla script actions 2024-05-21 14:13:27 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-reqwest-retry

Comment 7 Fedora Update System 2024-05-21 15:04:37 UTC
FEDORA-2024-1b340978b0 (rust-reqwest-retry-0.5.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-1b340978b0

Comment 8 Fedora Update System 2024-05-21 15:26:11 UTC
FEDORA-2024-1b340978b0 (rust-reqwest-retry-0.5.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 9 Fedora Update System 2024-05-21 15:28:50 UTC
FEDORA-2024-c2abca435e (rust-async_http_range_reader-0.8.0-1.fc40, rust-bisection-0.1.0-2.fc40, and 6 more) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e

Comment 10 Fedora Update System 2024-05-21 15:36:06 UTC
FEDORA-2024-0bfd6dabc2 (rust-async_http_range_reader-0.8.0-1.fc39, rust-bisection-0.1.0-2.fc39, and 6 more) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2

Comment 11 Fedora Update System 2024-05-22 01:11:37 UTC
FEDORA-2024-c2abca435e has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-c2abca435e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2024-05-22 01:48:40 UTC
FEDORA-2024-0bfd6dabc2 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0bfd6dabc2 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Fedora Update System 2024-05-30 01:19:42 UTC
FEDORA-2024-0bfd6dabc2 (rust-async_http_range_reader-0.8.0-1.fc39, rust-bisection-0.1.0-2.fc39, and 6 more) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-05-30 01:21:08 UTC
FEDORA-2024-c2abca435e (rust-async_http_range_reader-0.8.0-1.fc40, rust-bisection-0.1.0-2.fc40, and 6 more) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.