Bug 227719

Summary:	Review Request: gpixpod - An ipod photo organizer
Product:	[Fedora] Fedora	Reporter:	Deji Akingunola <dakingun>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	Flags:	notting: fedora-cvs+
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2007-02-13 22:28:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779

Description Deji Akingunola 2007-02-07 18:55:31 UTC

Spec URL: ftp://czar.eas.yorku.ca/pub/gpixpod/gpixpod.spec
SRPM URL: ftp://czar.eas.yorku.ca/pub/gpixpod/gpixpod-0.6.2-1.src.rpm
Description: 
GPixPod let you manage your collection of photos uploading
them to your iPod, organizing them in photo albums.
Instead of the iTunes synchronization approach, GPixPod 
let you choose your manual operations on your photos and
photo albums, such as adding/deleting individual photos
and photo albums, and renaming photo albums

Comment 1 Parag AN(पराग) 2007-02-08 14:20:15 UTC

mock build is fine
rpmlint  is silent.
will review tomorrow

Comment 2 Parag AN(पराग) 2007-02-09 04:51:32 UTC

Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPMS.
+ source files match upstream.
2136a65e7b72ba5f5cd7ae5ebdc2205c  gpixpod-0.6.2.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Dose owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Desktop files installed correctly.
+ python guidelines followed.
+ GUI app.

APPROVED.