Bug 2277416

Summary: Review Request: golang-github-dlintw-goconf - Configuration file parser for go
Product: [Fedora] Fedora Reporter: Renich Bon Ciric <renich>
Component: Package ReviewAssignee: Mikel Olasagasti Uranga <mikel>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: mikel, package-review
Target Milestone: ---Flags: mikel: fedora-review+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-05-04 02:47:58 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2277423    

Description Renich Bon Ciric 2024-04-26 20:14:30 UTC
Spec URL: https://fedorapeople.org/~renich/signaling/golang-github-dlintw-goconf.spec
SRPM URL: https://fedorapeople.org/~renich/signaling/golang-github-dlintw-goconf-0-0.1.20240423gitdcc0709.fc39.src.rpm
Description: Goconf is a configuration file parser for the Go Programming Language. It is based on goconfig.
Fedora Account System Username: renich

Comment 1 Mikel Olasagasti Uranga 2024-04-26 20:28:30 UTC
> Summary:        Goconf is a configuration file parser for the Go Programming Language. It is based on goconfig.

What about something like this: Configuration file parser based on goconfig.

> %global common_description %{expand:
> Goconf package - fork from http://code.google.com/p/goconf/.}

You can use the Summary proposal here, just end it with the dot.

Comment 2 Renich Bon Ciric 2024-04-26 22:09:11 UTC
OK, updated the SPEC and SRPM now.

Comment 3 Mikel Olasagasti Uranga 2024-04-27 11:12:36 UTC
Summary is still too large, it was not changed. Please, do change it before importing.

Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.

Thanks!

Comment 4 Fedora Admin user for bugzilla script actions 2024-05-04 02:29:39 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-dlintw-goconf

Comment 5 Fedora Update System 2024-05-04 02:45:16 UTC
FEDORA-2024-bccf212af6 (golang-github-dlintw-goconf-0-0.1.20240423gitdcc0709.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-bccf212af6

Comment 6 Fedora Update System 2024-05-04 02:47:58 UTC
FEDORA-2024-bccf212af6 (golang-github-dlintw-goconf-0-0.1.20240423gitdcc0709.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.