Bug 2277628
| Summary: | Review Request: rust-minreq - Simple, minimal-dependency HTTP client | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Davide Cavalca <davide> |
| Component: | Package Review | Assignee: | Michel Lind <michel> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | decathorpe, michel, package-review |
| Target Milestone: | --- | Flags: | michel:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-05-02 00:15:16 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Davide Cavalca
2024-04-28 18:32:24 UTC
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=116993757 I had some comments on the review request that was superseded by this one, you might want to take a look: https://bugzilla.redhat.com/show_bug.cgi?id=2184883#c5 Thanks! I'm stripping native_tls in %prep so 1 should be addressed. 2 isn't relevant for this review. 3 should be fine (I'd packaged punycode earlier). 4 is addressed. That leaves 5 -- is the arch restriction still relevant? I don't see an ExcludeArch on rust-rustls or rust-ring, it looks like there's available on all arches now? fwiw the thing I'm packaging this for does use the https-rustls feature: https://github.com/facebookexperimental/resctl-demo/blob/main/resctl-bench/Cargo.toml#L44 Thank you for checking! Yes, rustls is now available on all architectures. I want sticker support so I can react accordingly to some of what I see inside this package, but... Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (ISC ... why) and is acceptable for Fedora - bundled native-tls is MIT but is deleted - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks (use `fedora-sig-onboard onboard rust-$crate` to automate): - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer) The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-minreq FEDORA-2024-8addab2264 (rust-minreq-2.11.2-1.fc41, rust-rd-agent-2.2.5-1.fc41, and 7 more) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8addab2264 FEDORA-2024-8addab2264 (rust-minreq-2.11.2-1.fc41, rust-rd-agent-2.2.5-1.fc41, and 7 more) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report. |