Bug 2277710
| Summary: | Review Request: perl-Text-Lorem - Generate random Latin looking text | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jitka Plesnikova <jplesnik> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Text-Lorem-0.34-1.fc41 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2024-04-30 11:48:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 2277730 | ||
|
Description
Jitka Plesnikova
2024-04-29 11:10:15 UTC
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. URL and Source0 addresses are Ok.
Source0 archive (SHA-512 c6d7f0e5dad59ce72bd86e84350a422f663289433508e125a592e6996a66578dfed50daa4904c7db76f6a90409673a2b2fcde9d660bb49e2e2efafeb887a0cfc) is original. Ok.
Summary verified from lib/Text/Lorem.pm. Ok.
Description verified from lib/Text/Lorem.pm. Ok.
License verified from README, lib/Text/Lorem.pm, and Makefile.PL.
No XS code, noarch BuildArch is Ok.
All tests pass. Ok.
TODO: Consider running the tests in parallel by setting HARNESS_OPTIONS variable.
$ rpmlint perl-Text-Lorem.spec ../SRPMS/perl-Text-Lorem-0.34-1.fc41.src.rpm ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
/usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
/etc/xdg/rpmlint/fedora-legacy-licenses.toml
/etc/xdg/rpmlint/fedora-spdx-licenses.toml
/etc/xdg/rpmlint/fedora.toml
/etc/xdg/rpmlint/scoring.toml
/etc/xdg/rpmlint/users-groups.toml
/etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3
=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
rpmlint is OK.
$ rpm -q -lv -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm
-rwxr-xr-x 1 root root 1211 Apr 29 02:00 /usr/bin/lorem
drwxr-xr-x 2 root root 0 Apr 29 02:00 /usr/share/doc/perl-Text-Lorem
-rw-r--r-- 1 root root 595 Feb 25 2021 /usr/share/doc/perl-Text-Lorem/CHANGES
-rw-r--r-- 1 root root 1661 Feb 25 2021 /usr/share/doc/perl-Text-Lorem/README
-rw-r--r-- 1 root root 1073 Apr 29 02:00 /usr/share/man/man1/lorem.1.gz
-rw-r--r-- 1 root root 1592 Apr 29 02:00 /usr/share/man/man3/Text::Lorem.3pm.gz
-rw-r--r-- 1 root root 4796 Feb 25 2021 /usr/share/perl5/vendor_perl/Text/Lorem.pm
FIX: Package %{perl_vendorlib}/Text directory.
$ rpm -q --requires -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm | sort -f | uniq -c
1 /usr/bin/perl
1 perl(Getopt::Std)
1 perl(strict)
1 perl(Text::Lorem)
1 perl(vars)
1 perl(warnings)
1 perl-libs
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary Requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm | sort -f | uniq -c
1 perl(Text::Lorem) = 0.34
1 perl-Text-Lorem = 0.34-1.fc41
Binary Provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-Text-Lorem-0.34-1.fc41.noarch.rpm
Binary dependencies are resolvable. Ok.
The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=117068208). Ok.
Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Please correct the FIX item and consider fixing the TODO item before building this package.
Resolution: Package is APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Text-Lorem Thank you for the review. |