Bug 2277730

Summary:	Review Request: perl-Data-Fake - Declaratively generate fake structured data for testing
Product:	[Fedora] Fedora	Reporter:	Jitka Plesnikova <jplesnik>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-Data-Fake-0.006-1.fc41	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-05-06 08:05:58 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2277710
Bug Blocks:	2277607

Description Jitka Plesnikova 2024-04-29 11:42:40 UTC

Spec URL: https://jplesnik.fedorapeople.org/perl-Data-Fake/perl-Data-Fake.spec
SRPM URL: https://jplesnik.fedorapeople.org/perl-Data-Fake/perl-Data-Fake-0.006-1.fc41.src.rpm
Description: This module generates randomized, fake structured data using
declarative syntax.

Fedora Account System Username: jplesnik

Comment 1 Fedora Review Service 2024-04-29 11:43:05 UTC

Cannot find any valid SRPM URL for this ticket. Common causes are:

- You didn't specify `SRPM URL: ...` in the ticket description
  or any of your comments
- The URL schema isn't HTTP or HTTPS
- The SRPM package linked in your URL doesn't match the package name specified
  in the ticket summary


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Petr Pisar 2024-05-02 12:17:46 UTC

Standalone spec file and packages spec file differ. I will use the standalone one because it's newer.

URL and Source0 addresses are Ok.
Source0 archive (SHA-512 1d36a9f66c0cd90ae93200752b2e2786df02d10fbe61be45464edadb6bae5ac157830c0b56bf2943e59a9949b82e8e96f1351258a48ef6f12535cdc89f20d171) is original. Ok.
Summary verified from lib/Data/Fake.pm. OK.
Description verified from lib/Data/Fake.pm. OK.
License verified from LICENSE, t/core.t, t/text.t, t/internet.t, t/api.t, t/names.t, t/dates.t, t/company.t, README, lib/Data/Fake.pm, lib/Data/Fake/Examples.pod, lib/Data/Fake/Company.pm, lib/Data/Fake/Internet.pm, lib/Data/Fake/Core.pm, lib/Data/Fake/Names.pm, lib/Data/Fake/Text.pm, lib/Data/Fake/Dates.pm, Makefile.PL, and dist.ini. Ok.
No XS code, noarch BuildArch is Ok.

TODO: Unset AUTHOR_TESTING environment variable in %check phase as it influences t/00-report-prereqs.t.

All tests pass. Ok.

$ rpmlint perl-Data-Fake.spec ../SRPMS/perl-Data-Fake-0.006-1.fc41.src.rpm ../RPMS/noarch/perl-Data-Fake-0.006-1.fc41.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

perl-Data-Fake.noarch: E: spelling-error ('Declaratively', 'Summary(en_US) Declaratively -> Declarative, Decoratively, Attractively')
perl-Data-Fake.src: E: spelling-error ('Declaratively', 'Summary(en_US) Declaratively -> Declarative, Decoratively, Attractively')
=== 2 packages and 1 specfiles checked; 2 errors, 0 warnings, 6 filtered, 2 badness; has taken 0.4 s ==

rpmlint is Ok.


$ rpm -q -lv -p ../RPMS/noarch/perl-Data-Fake-0.006-1.fc41.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Apr 29 02:00 /usr/share/doc/perl-Data-Fake
-rw-r--r--    1 root     root                     3460 Feb 26  2021 /usr/share/doc/perl-Data-Fake/CONTRIBUTING.mkdn
-rw-r--r--    1 root     root                      983 Feb 26  2021 /usr/share/doc/perl-Data-Fake/Changes
-rw-r--r--    1 root     root                     6763 Feb 26  2021 /usr/share/doc/perl-Data-Fake/README
drwxr-xr-x    2 root     root                        0 Apr 29 02:00 /usr/share/doc/perl-Data-Fake/examples
-rw-r--r--    1 root     root                      455 Feb 26  2021 /usr/share/doc/perl-Data-Fake/examples/synopsis.pl
-rw-r--r--    1 root     root                      279 Feb 26  2021 /usr/share/doc/perl-Data-Fake/examples/urls.pl
drwxr-xr-x    2 root     root                        0 Apr 29 02:00 /usr/share/licenses/perl-Data-Fake
-rw-r--r--    1 root     root                    11500 Feb 26  2021 /usr/share/licenses/perl-Data-Fake/LICENSE
-rw-r--r--    1 root     root                     3461 Apr 29 02:00 /usr/share/man/man3/Data::Fake.3pm.gz
-rw-r--r--    1 root     root                     1297 Apr 29 02:00 /usr/share/man/man3/Data::Fake::Company.3pm.gz
-rw-r--r--    1 root     root                     3258 Apr 29 02:00 /usr/share/man/man3/Data::Fake::Core.3pm.gz
-rw-r--r--    1 root     root                     1599 Apr 29 02:00 /usr/share/man/man3/Data::Fake::Dates.3pm.gz
-rw-r--r--    1 root     root                     1252 Apr 29 02:00 /usr/share/man/man3/Data::Fake::Examples.3pm.gz
-rw-r--r--    1 root     root                     1393 Apr 29 02:00 /usr/share/man/man3/Data::Fake::Internet.3pm.gz
-rw-r--r--    1 root     root                     1402 Apr 29 02:00 /usr/share/man/man3/Data::Fake::Names.3pm.gz
-rw-r--r--    1 root     root                     1470 Apr 29 02:00 /usr/share/man/man3/Data::Fake::Text.3pm.gz
drwxr-xr-x    2 root     root                        0 Apr 29 02:00 /usr/share/perl5/vendor_perl/Data
drwxr-xr-x    2 root     root                        0 Apr 29 02:00 /usr/share/perl5/vendor_perl/Data/Fake
-rw-r--r--    1 root     root                     7111 Feb 26  2021 /usr/share/perl5/vendor_perl/Data/Fake.pm
-rw-r--r--    1 root     root                     4890 Feb 26  2021 /usr/share/perl5/vendor_perl/Data/Fake/Company.pm
-rw-r--r--    1 root     root                    17523 Feb 26  2021 /usr/share/perl5/vendor_perl/Data/Fake/Core.pm
-rw-r--r--    1 root     root                     4643 Feb 26  2021 /usr/share/perl5/vendor_perl/Data/Fake/Dates.pm
-rw-r--r--    1 root     root                      876 Feb 26  2021 /usr/share/perl5/vendor_perl/Data/Fake/Examples.pod
-rw-r--r--    1 root     root                     3783 Feb 26  2021 /usr/share/perl5/vendor_perl/Data/Fake/Internet.pm
-rw-r--r--    1 root     root                    24630 Feb 26  2021 /usr/share/perl5/vendor_perl/Data/Fake/Names.pm
-rw-r--r--    1 root     root                     4411 Feb 26  2021 /usr/share/perl5/vendor_perl/Data/Fake/Text.pm
TODO: I recommend not packaging CONTRIBUTING.mkdn as it does not provide information helpful for the packaged files (the documented procedure only works if you have unpacked the source archive) and it isn't specific to this piece of software.

$ rpm -q --requires -p ../RPMS/noarch/perl-Data-Fake-0.006-1.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(:VERSION) >= 5.8.1
      1 perl(Carp)
      1 perl(Data::Fake::Core)
      1 perl(Data::Fake::Names)
      1 perl(Data::Fake::Text)
      1 perl(Exporter) >= 5.57
      1 perl(Import::Into) >= 1.002005
      1 perl(List::Util)
      1 perl(strict)
      1 perl(Text::Lorem)
      1 perl(Time::Piece) >= 1.27
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Data-Fake-0.006-1.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(Data::Fake) = 0.006
      1 perl(Data::Fake::Company) = 0.006
      1 perl(Data::Fake::Core) = 0.006
      1 perl(Data::Fake::Dates) = 0.006
      1 perl(Data::Fake::Internet) = 0.006
      1 perl(Data::Fake::Names) = 0.006
      1 perl(Data::Fake::Text) = 0.006
      1 perl-Data-Fake = 0.006-1.fc41
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Data-Fake-0.006-1.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora 41 (https://koji.fedoraproject.org/koji/taskinfo?taskID=117152051). Ok.

The package is in line with Fedora and Perl packaging guidelines.
Please consider fixing the TODO items before building this package.
Resolution: Package APPROVED.

Comment 3 Fedora Admin user for bugzilla script actions 2024-05-06 06:18:58 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Data-Fake