Bug 2279009
Summary: | Review Request: aws-c-io - IO package for AWS SDK for C | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Dominik Wombacher <dominik> | ||||||
Component: | Package Review | Assignee: | Neil Hanlon <neil> | ||||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | rawhide | CC: | code, davdunc, domwom, mhayden, neil, ngompa13, package-review | ||||||
Target Milestone: | --- | Keywords: | AutomationTriaged | ||||||
Target Release: | --- | Flags: | neil:
fedora-review+
|
||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
URL: | https://github.com/awslabs/%{name} | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2024-06-06 08:56:10 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | 2049400, 2279003, 2279006, 2279007, 2279008 | ||||||||
Bug Blocks: | 2279010, 2279011 | ||||||||
Attachments: |
|
Description
Dominik Wombacher
2024-05-03 22:30:39 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7403155 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279009-aws-c-io/fedora-rawhide-x86_64/07403155-aws-c-io/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Packaging order based on dependencies between AWS C libs: 1. aws-c-common [1][2] 2. aws-c-cal [3], aws-c-sdkutils [4], aws-c-compression [5], aws-checksums [6] 3. s2n-tls [7], aws-c-io [8] 4. aws-c-http [9], aws-c-event-stream [10] 5. aws-c-auth [11], aws-c-mqtt [12] 6. aws-c-s3 [13] [1] https://bugzilla.redhat.com/show_bug.cgi?id=2240798 [2] https://bugzilla.redhat.com/show_bug.cgi?id=2246663 [3] https://bugzilla.redhat.com/show_bug.cgi?id=2049400 [4] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279003 [5] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279006 [6] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279007 [7] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279008 [8] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279009 [9] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279010 [10] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279011 [11] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279012 [12] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279013 [13] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279014 Updated spec based on feedback received in review request of depending package: https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279008 Pretty likely that some of those findings would also come up in this request otherwise. Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07446424-aws-c-io/aws-c-io-0.14.8-1.fc41.src.rpm SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07446424-aws-c-io/aws-c-io.spec Created attachment 2033356 [details]
The .spec file difference from Copr build 7403155 to 7446472
Copr build: https://copr.fedorainfracloud.org/coprs/build/7446472 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279009-aws-c-io/fedora-rawhide-x86_64/07446472-aws-c-io/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Fedora Review Service triggered build failed because it depends on / is blocked by https://bugzilla.redhat.com/show_bug.cgi?id=2279008 Another update to fix a couple of things in the spec file. Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07446827-aws-c-io/aws-c-io.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07446827-aws-c-io/aws-c-io-0.14.8-1.fc41.src.rpm The next Fedora Review Service build will continue to fail because of the missing dependency though. Created attachment 2033399 [details]
The .spec file difference from Copr build 7446472 to 7446839
Copr build: https://copr.fedorainfracloud.org/coprs/build/7446839 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279009-aws-c-io/fedora-rawhide-x86_64/07446839-aws-c-io/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Dependency https://bugzilla.redhat.com/show_bug.cgi?id=2279008 approved and available in rawhide. Builds on rawhide should be fine now, let's trigger a new one. [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/7461868 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279009-aws-c-io/fedora-rawhide-x86_64/07461868-aws-c-io/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Review complete, no issues found (skipping template) **Approved** The Pagure repository was created at https://src.fedoraproject.org/rpms/aws-c-io |