Bug 2279010

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7403159
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279010-aws-c-http/fedora-rawhide-x86_64/07403159-aws-c-http/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Packaging order based on dependencies between AWS C libs:

1. aws-c-common [1][2]
2. aws-c-cal [3], aws-c-sdkutils [4], aws-c-compression [5], aws-checksums [6]
3. s2n-tls [7], aws-c-io [8]
4. aws-c-http [9], aws-c-event-stream [10]
5. aws-c-auth [11], aws-c-mqtt [12]
6. aws-c-s3 [13]


[1] https://bugzilla.redhat.com/show_bug.cgi?id=2240798
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2246663
[3] https://bugzilla.redhat.com/show_bug.cgi?id=2049400
[4] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279003
[5] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279006
[6] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279007
[7] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279008
[8] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279009
[9] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279010
[10] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279011
[11] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279012
[12] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279013
[13] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279014

Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07722282-aws-c-http/aws-c-http.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07722282-aws-c-http/aws-c-http-0.8.2-1.fc41.src.rpm

Builds fine on f39, f49, rawhide, epel8 and epel9.
Unit tests fail on f39, f40, rawhide on aarch64.
But are ok on f39, f40, rawhide, epel8 and epel9 x86_64 as well as epel8 and epel9 aarch64.

Issue raised in upstream project regarding the failing unit tests (f39, f40, rawhide on aarch64): https://github.com/awslabs/aws-c-http/issues/473

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7726875
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279010-aws-c-http/fedora-rawhide-x86_64/07726875-aws-c-http/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

I see one issue in your spec:

In the libs subpackage, you have:

> Requires:       %{name}%{?_isa} = %{version}-%{release}

This probably should be on the main subpackage instead to have it require the libs subpackage.

(In reply to Neal Gompa from comment #5)
> I see one issue in your spec:
> 
> In the libs subpackage, you have:
> 
> > Requires:       %{name}%{?_isa} = %{version}-%{release}
> 
> This probably should be on the main subpackage instead to have it require
> the libs subpackage.

Moved it to the main package and dropped it from the libs sub-package.

```
diff --git a/aws-c-http.spec b/aws-c-http.spec
index 5922970..fa16495 100755
--- a/aws-c-http.spec
+++ b/aws-c-http.spec
@@ -19,6 +19,8 @@ BuildRequires:  numactl-devel
 BuildRequires:  aws-c-compression-devel
 BuildRequires:  aws-c-io-devel
 
+Requires:       %{name}-libs%{?_isa} = %{version}-%{release}
+
 # https://fedoraproject.org/wiki/Changes/EncourageI686LeafRemoval
 ExcludeArch:    %{ix86}
 # Dependencies like aws-c-common don't support and build on s390x
@@ -31,7 +33,6 @@ ExcludeArch: s390x
 
 %package libs
 Summary:        %{summary}
-Requires:       %{name}%{?_isa} = %{version}-%{release}
```

local mockbuild and copr build successful: https://copr.fedorainfracloud.org/coprs/wombelix/aws-c-libs/build/7776067/

Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07776067-aws-c-http/aws-c-http.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07776067-aws-c-http/aws-c-http-0.8.2-1.fc41.src.rpm

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled and recorded
* No serious issues from rpmlint

PACKAGE APPROVED.

The Pagure repository was created at https://src.fedoraproject.org/rpms/aws-c-http