Bug 2279011

Summary: Review Request: aws-c-event-stream - C99 implementation of the vnd.amazon.eventstream content-type
Product: [Fedora] Fedora Reporter: Dominik Wombacher <dominik>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: davdunc, domwom, mhayden, ngompa13, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: ngompa13: fedora-review+
Hardware: All   
OS: Linux   
URL: https://github.com/awslabs/%{name}
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-23 09:38:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 2279008, 2279009    
Bug Blocks: 2279012, 2279013    

Description Dominik Wombacher 2024-05-03 22:36:52 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07402777-aws-c-event-stream/aws-c-event-stream.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07402777-aws-c-event-stream/aws-c-event-stream-0.4.2-1.fc41.src.rpm
Description: C99 implementation of the vnd.amazon.eventstream content-type
Fedora Account System Username: wombelix
Comment 1 Fedora Review Service 2024-05-03 22:39:44 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7403161
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279011-aws-c-event-stream/fedora-rawhide-x86_64/07403161-aws-c-event-stream/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 2 Dominik Wombacher 2024-05-03 22:51:30 UTC 
Packaging order based on dependencies between AWS C libs:

1. aws-c-common [1][2]
2. aws-c-cal [3], aws-c-sdkutils [4], aws-c-compression [5], aws-checksums [6]
3. s2n-tls [7], aws-c-io [8]
4. aws-c-http [9], aws-c-event-stream [10]
5. aws-c-auth [11], aws-c-mqtt [12]
6. aws-c-s3 [13]


[1] https://bugzilla.redhat.com/show_bug.cgi?id=2240798
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2246663
[3] https://bugzilla.redhat.com/show_bug.cgi?id=2049400
[4] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279003
[5] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279006
[6] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279007
[7] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279008
[8] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279009
[9] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279010
[10] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279011
[11] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279012
[12] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279013
[13] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279014
Comment 3 Dominik Wombacher 2024-07-10 10:35:45 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07722169-aws-c-event-stream/aws-c-event-stream.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07722169-aws-c-event-stream/aws-c-event-stream-0.4.2-1.fc41.src.rpm
Comment 4 Fedora Review Service 2024-07-10 20:30:28 UTC 
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7723395
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279011-aws-c-event-stream/fedora-rawhide-x86_64/07723395-aws-c-event-stream/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.
Comment 5 Neal Gompa 2024-07-22 22:55:39 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled and recorded
* No serious issues from rpmlint

PACKAGE APPROVED.
Comment 6 Fedora Admin user for bugzilla script actions 2024-07-23 09:16:43 UTC 
The Pagure repository was created at https://src.fedoraproject.org/rpms/aws-c-event-stream