Bug 2279013

Summary:	Review Request: aws-c-mqtt - C99 implementation of the MQTT 3.1.1 and MQTT 5 specifications.
Product:	[Fedora] Fedora	Reporter:	Dominik Wombacher <dominik>
Component:	Package Review	Assignee:	Neal Gompa <ngompa13>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	davdunc, domwom, ngompa13, package-review
Target Milestone:	---	Flags:	ngompa13: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
URL:	https://github.com/awslabs/%{name}
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-09-27 09:00:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	2279010, 2279011
Bug Blocks:	2279014

Description Dominik Wombacher 2024-05-03 22:45:11 UTC

Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07402779-aws-c-mqtt/aws-c-mqtt.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07402779-aws-c-mqtt/aws-c-mqtt-0.10.4-1.fc41.src.rpm
Description: C99 implementation of the MQTT 3.1.1 and MQTT 5 specifications.
Fedora Account System Username: wombelix

Comment 1 Fedora Review Service 2024-05-03 22:47:11 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7403166
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279013-aws-c-mqtt/fedora-rawhide-x86_64/07403166-aws-c-mqtt/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Dominik Wombacher 2024-05-03 22:51:49 UTC

Packaging order based on dependencies between AWS C libs:

1. aws-c-common [1][2]
2. aws-c-cal [3], aws-c-sdkutils [4], aws-c-compression [5], aws-checksums [6]
3. s2n-tls [7], aws-c-io [8]
4. aws-c-http [9], aws-c-event-stream [10]
5. aws-c-auth [11], aws-c-mqtt [12]
6. aws-c-s3 [13]


[1] https://bugzilla.redhat.com/show_bug.cgi?id=2240798
[2] https://bugzilla.redhat.com/show_bug.cgi?id=2246663
[3] https://bugzilla.redhat.com/show_bug.cgi?id=2049400
[4] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279003
[5] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279006
[6] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279007
[7] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279008
[8] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279009
[9] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279010
[10] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279011
[11] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279012
[12] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279013
[13] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279014

Comment 3 Dominik Wombacher 2024-08-12 12:15:36 UTC

Minor changes in the spec to align with other aws-c-libs I maintain.
All dependencies available in fedora, package ready for review.

Copr builds for f39, f40, rawhide, epel8, epel9 on x86_64 and aarch64 successful:
- https://copr.fedorainfracloud.org/coprs/wombelix/aws-c-libs/build/7901058/
- https://copr.fedorainfracloud.org/coprs/wombelix/aws-c-libs/build/7901133/

Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07901058-aws-c-mqtt/aws-c-mqtt.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/07901058-aws-c-mqtt/aws-c-mqtt-0.10.4-1.fc41.src.rpm

Comment 4 Neal Gompa 2024-09-23 12:08:18 UTC

Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled and recorded
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2024-09-26 11:54:07 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/aws-c-mqtt