Bug 2279014
| Summary: | Review Request: aws-c-s3 - C99 library implementation for communicating with the S3 service | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dominik Wombacher <dominik> |
| Component: | Package Review | Assignee: | Neil Hanlon <neil> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | davdunc, domwom, neil, ngompa13, package-review |
| Target Milestone: | --- | Keywords: | AutomationTriaged |
| Target Release: | --- | Flags: | neil:
fedora-review+
|
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | https://github.com/awslabs/%{name} | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2025-05-12 14:38:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 2279012, 2279013 | ||
| Bug Blocks: | |||
|
Description
Dominik Wombacher
2024-05-03 22:47:56 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7403168 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279014-aws-c-s3/fedora-rawhide-x86_64/07403168-aws-c-s3/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Packaging order based on dependencies between AWS C libs: 1. aws-c-common [1][2] 2. aws-c-cal [3], aws-c-sdkutils [4], aws-c-compression [5], aws-checksums [6] 3. s2n-tls [7], aws-c-io [8] 4. aws-c-http [9], aws-c-event-stream [10] 5. aws-c-auth [11], aws-c-mqtt [12] 6. aws-c-s3 [13] [1] https://bugzilla.redhat.com/show_bug.cgi?id=2240798 [2] https://bugzilla.redhat.com/show_bug.cgi?id=2246663 [3] https://bugzilla.redhat.com/show_bug.cgi?id=2049400 [4] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279003 [5] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279006 [6] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279007 [7] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279008 [8] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279009 [9] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279010 [10] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279011 [11] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279012 [12] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279013 [13] https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=2279014 Updated to latest release (0.6.6). Spec URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/08091638-aws-c-s3/aws-c-s3.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/wombelix/aws-c-libs/fedora-rawhide-x86_64/08091638-aws-c-s3/aws-c-s3-0.6.6-1.fc42.src.rpm Copr build: https://copr.fedorainfracloud.org/coprs/build/8091642 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279014-aws-c-s3/fedora-rawhide-x86_64/08091642-aws-c-s3/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. FYI: It's expected that the build currently fails on any Fedora version other than rawhide (https://copr.fedorainfracloud.org/coprs/build/8091642). Dependency 'aws-c-auth' is in testing and arrives in f39, f40 and f41 within the next days. Notes:
1) -doc package should be BuildArch: noarch
2) soname looks odd, per rpmlint: aws-c-s3-libs.x86_64: E: invalid-soname /usr/lib64/libaws-c-s3.so.1.0.0 libaws-c-s3.so.0unstable
Otherwise looks good. Will be approved with clarification for soname ('unstable')
@neil thanks for doing the review! Regarding the SONAME, that comes from upstream, they add the `unstable` suffix here: https://github.com/awslabs/aws-c-s3/blob/5877f40f87c77ccf2b278839995a6ee91983080f/CMakeLists.txt#L85 It looks like that the majority of AWS C lib packages had this but dropped that at some point but it's still in aws-c-s3. What is your suggestion? Just moving on as is? Patch it out in our package so that only the version one line up (https://github.com/awslabs/aws-c-s3/blob/5877f40f87c77ccf2b278839995a6ee91983080f/CMakeLists.txt#L84) is used? Oops, I thought I had responded to this... I think that's probably fine, as it appears it's intentional from upstream. Approved! The Pagure repository was created at https://src.fedoraproject.org/rpms/aws-c-s3 |