Bug 2279158
| Summary: | Review Request: python-triton-rocm - A language and compiler for custom Deep Learning operations | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tom Rix <trix> |
| Component: | Package Review | Assignee: | Tomas Tomecek <ttomecek> |
| Status: | ASSIGNED --- | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | alexjnewt, fschwarz, package-review, rocm-packagers-sig, ttomecek |
| Target Milestone: | --- | Flags: | ttomecek:
fedora-review?
|
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Linux | ||
| URL: | https://github.com/ROCm/triton/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | Type: | --- | |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tom Rix
2024-05-05 14:44:39 UTC
Copr build: https://copr.fedorainfracloud.org/coprs/build/7411626 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279158-python-triton-rocm/fedora-rawhide-x86_64/07411626-python-triton-rocm/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. Tom, I'll need help from you on this one. Tried to build it locally twice but failed :/ I can see the copr build above also wasn't successful, sadly logs are no longer available. My local log snippet: [2148/4235] : && /usr/bin/cmake -E rm -f lib/libLLVMAMDGPUDisassembler.a && /usr/bin/ar Dqc lib/libLLVMAMDGPUDisassembler.a lib/Target/AMDGPU/Disassembler/CMakeFiles/LLVMAMDGPUDisassembler.dir/AMDGPUDisassembler.cpp.o && /usr/bin/ranlib -D lib/libLLVMAMDGPUDisassembler.a && : [2149/4235] : && /usr/bin/cmake -E rm -f lib/libLLVMAMDGPUTargetMCA.a && /usr/bin/ar Dqc lib/libLLVMAMDGPUTargetMCA.a lib/Target/AMDGPU/MCA/CMakeFiles/LLVMAMDGPUTargetMCA.dir/AMDGPUCustomBehaviour.cpp.o && /usr/bin/ranlib -D lib/libLLVMAMDGPUTargetMCA.a && : FAILED: lib/libLLVMAMDGPUTargetMCA.a : && /usr/bin/cmake -E rm -f lib/libLLVMAMDGPUTargetMCA.a && /usr/bin/ar Dqc lib/libLLVMAMDGPUTargetMCA.a lib/Target/AMDGPU/MCA/CMakeFiles/LLVMAMDGPUTargetMCA.dir/AMDGPUCustomBehaviour.cpp.o && /usr/bin/ranlib -D lib/libLLVMAMDGPUTargetMCA.a && : /usr/bin/ranlib: unable to copy file 'lib/libLLVMAMDGPUTargetMCA.a'; reason: Input/output error Let's also retry the copr build [fedora-review-service-build] Copr build: https://copr.fedorainfracloud.org/coprs/build/7479535 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279158-python-triton-rocm/fedora-rawhide-x86_64/07479535-python-triton-rocm/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string. I am stuck now. I cannot build this locally on my T14s lenovo nor on Copr powerful machines: https://copr.fedorainfracloud.org/coprs/ttomecek/review-2279158-python-triton-rocm/build/7512525/ Tom, can you share a build with me so that I can test it out? I'll follow with fedora-review then. Commit 54d0bb9e4b2e2dab7dc899008c0f14915f665a2f has `version="2.2.0"` in setup.py, while the spec file has `%global pypi_version 2.3.0`, the versioning is very confusing to me, I couldn't find any mention of 2.3 (as of June 6th) in both upstream triton repos. How relevant is /usr/lib64/python3.12/site-packages/triton/third_party/hip? there is a bunch of files shipped there. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Header files in -devel subpackage, if present. Note: python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/AnalysisROCM/Alias.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/AnalysisROCM/Allocation.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/AnalysisROCM/AxisInfo.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/AnalysisROCM/Membar.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/AnalysisROCM/Utility.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Conversion/TritonGPUROCMToLLVM/AsmFormat.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Conversion/TritonGPUROCMToLLVM/GCNAsmFormat.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Conversion/TritonGPUROCMToLLVM/PTXAsmFormat.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Conversion/TritonGPUROCMToLLVM/Passes.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Conversion/TritonGPUROCMToLLVM/TritonGPUToLLVMPass.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Conversion/TritonToTritonGPUROCM/Passes.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Conversion/TritonToTritonGPUROCM/TritonToTritonGPUPass.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Dialect/TritonGPUROCM/IR/Attributes.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Dialect/TritonGPUROCM/IR/Dialect.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Dialect/TritonGPUROCM/IR/Traits.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Dialect/TritonGPUROCM/IR/Types.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Dialect/TritonGPUROCM/Transforms/Passes.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Dialect/TritonGPUROCM/Transforms/TritonGPUConversion.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Dialect/TritonGPUROCM/Transforms/Utility.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/include/triton/Target/HSACO/HSACOTranslation.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/BarrierOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/ClusterOpsToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/ConvertLayoutOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/DotOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/ElementwiseOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/LoadStoreOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/ReduceOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/RegReallocOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/ScanOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/TensorPtrOpsToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/TritonGPUToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/TritonGPUToLLVMBase.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/TypeConverter.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/Utility.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/ViewOpToLLVM.h python3-triton-rocm : /usr/lib64/python3.12/site- packages/triton/tools/compile.h See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== C/C++: [x]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* Apache License 2.0", "BSD 3-Clause License", "*No copyright* MIT License", "*No copyright* Lawrence Berkeley National Labs BSD variant license", "BSD 2-Clause License", "Apache License 2.0", "*No copyright* Apache License 2.0 [generated file]", "GNU General Public License v2.0 or later [generated file]", "*No copyright* Creative Commons Attribution 3.0", "*No copyright* GNU General Public License, Version 3", "GNU General Public License", "*No copyright* Apache License", "GNU Lesser General Public License v2.1 or later", "University of Illinois/NCSA Open Source License", "*No copyright* Apache License 2.0 and/or Public domain", "Apache License 2.0 and/or Unicode License Agreement - Data Files and Software (2016)", "Apache License 2.0 and/or Boost Software License 1.0", "*No copyright* Creative Commons CC0 1.0", "Apache License 2.0 and/or Unicode License Agreement - Data Files and Software (2015)", "Public domain", "Apache License 2.0 and/or Unicode License Agreement - Data Files and Software (2016) [generated file]", "ISC License", "GNU Lesser General Public License v3.0 or later", "*No copyright* Apache License 2.0 and/or Creative Commons CC0 1.0", "FSF All Permissive License", "*No copyright* ISC License", "Apple Public Source License 2.0", "BSD 2-Clause with views sentence", "BSD 3-Clause License [generated file]". 96913 files have unknown license. Detailed output of licensecheck in /home/trix/work/ai/rocm- triton/triton/review-python-triton-rocm/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/python3.12/site-packages, /usr/lib64/python3.12 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 5867 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-triton-rocm [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-triton-rocm-2.3.0-1.fc41.x86_64.rpm python-triton-rocm-debugsource-2.3.0-1.fc41.x86_64.rpm python-triton-rocm-2.3.0-1.fc41.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2bemp48t')] checks: 32, packages: 3 python3-triton-rocm.x86_64: E: zero-length /usr/lib64/python3.12/site-packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/ElementwiseOpToLLVM/Fp8E4M3B15.cpp python3-triton-rocm.x86_64: E: zero-length /usr/lib64/python3.12/site-packages/triton/third_party/hip/lib/Conversion/TritonGPUROCMToLLVM/ElementwiseOpToLLVM/Fp8E5M2.cpp ... Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-triton-rocm.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/triton/_C/libtriton.so PyByteArray_Type (/usr/lib64/python3.12/site-packages/triton/_C/libtriton.so) python3-triton-rocm.x86_64: W: undefined-non-weak-symbol /usr/lib64/python3.12/site-packages/triton/_C/libtriton.so PyExc_RuntimeError (/usr/lib64/python3.12/site-packages/triton/_C/libtriton.so) ... Unversioned so-files -------------------- python3-triton-rocm: /usr/lib64/python3.12/site-packages/triton/_C/libtriton.so Source checksums ---------------- https://github.com/pybind/pybind11/archive/refs/tags/v2.11.1.tar.gz : CHECKSUM(SHA256) this package : d475978da0cdc2d43b73f30910786759d593a9d8ee05b1b6846d1eb16c6d2e0c CHECKSUM(SHA256) upstream package : d475978da0cdc2d43b73f30910786759d593a9d8ee05b1b6846d1eb16c6d2e0c https://github.com/llvm/llvm-project/archive/c5dede880d175f7229c9b2923f4753e12702305d.tar.gz : CHECKSUM(SHA256) this package : 6f371f9ac208b8e9dc57fc117b1a9c8565d7ea2bbb49a2768cb9c3c0fee0291d CHECKSUM(SHA256) upstream package : 6f371f9ac208b8e9dc57fc117b1a9c8565d7ea2bbb49a2768cb9c3c0fee0291d https://github.com/ROCm/triton//archive/54d0bb9e4b2e2dab7dc899008c0f14915f665a2f/triton-54d0bb9.tar.gz : CHECKSUM(SHA256) this package : 47c0e1a7d9da8e6a927ead6826fcb22768ccb722e316893f0cf6a1515e6ed3b7 CHECKSUM(SHA256) upstream package : 47c0e1a7d9da8e6a927ead6826fcb22768ccb722e316893f0cf6a1515e6ed3b7 Requires -------- python3-triton-rocm (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libhsa-runtime64.so.1()(64bit) libhsa-runtime64.so.1(ROCR_1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.11)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.2)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtinfo.so.6()(64bit) libz.so.1()(64bit) libz.so.1(ZLIB_1.2.0)(64bit) python(abi) python3.12dist(filelock) rtld(GNU_HASH) python-triton-rocm-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-triton-rocm: libtriton.so()(64bit) python-triton-rocm python3-triton-rocm python3-triton-rocm(x86-64) python3.12-triton-rocm python3.12dist(triton) python3dist(triton) python-triton-rocm-debugsource: python-triton-rocm-debugsource python-triton-rocm-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -v -n python-triton-rocm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic, Python Disabled plugins: Ruby, Ocaml, PHP, SugarActivity, Java, Haskell, R, fonts, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH |