Bug 2279552

Summary: python-pytest-testinfra fails to build with Python 3.13: ModuleNotFoundError: No module named 'crypt'
Product: [Fedora] Fedora Reporter: Karolina Surma <ksurma>
Component: python-pytest-testinfraAssignee: Martin Hoyer <mhoyer>
Status: CLOSED WORKSFORME QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: chedi.toueiti, cn137, fti-bugs, ksurma, mhoyer, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 10.1.1-2.fc41 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-06-21 00:11:05 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2260875, 2260877, 2244836    

Description Karolina Surma 2024-05-07 12:58:36 UTC
python-pytest-testinfra fails to build with Python 3.13.0a6.


==================================== ERRORS ====================================
____________________ ERROR collecting test/test_modules.py _____________________
ImportError while importing test module '/builddir/build/BUILD/pytest-testinfra-10.1.0/test/test_modules.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib64/python3.13/importlib/__init__.py:88: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test/test_modules.py:13: in <module>
    import crypt
E   ModuleNotFoundError: No module named 'crypt'

According to https://docs.python.org/3.13/whatsnew/3.13.html:

PEP 594: Remove the crypt module and its private _crypt extension, deprecated in Python 3.11.
The hashlib module is a potential replacement for certain use cases.
Otherwise, the following PyPI projects can be used:
- bcrypt: Modern password hashing for your software and your servers.
- passlib: Comprehensive password hashing framework supporting over 30 schemes.
- argon2-cffi: The secure Argon2 password hashing algorithm.
- legacycrypt: Wrapper to the POSIX crypt library call and associated functionality.
(Contributed by Victor Stinner in gh-104773.)

Also, please note that Fedora has packaged python-crypt-r which is the copy of the module from the standard library (https://github.com/fedora-python/crypt_r).


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/07419032-python-pytest-testinfra/

For all our attempts to build python-pytest-testinfra with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-pytest-testinfra/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Martin Hoyer 2024-05-07 13:27:57 UTC
Thanks Karolina, looking into it.

Comment 2 Martin Hoyer 2024-05-07 14:03:28 UTC
Created https://github.com/pytest-dev/pytest-testinfra/pull/764 in upstream.  
If there won't be a response, let's create a patch, as it only affects one simple test.

Comment 3 Miro Hrončok 2024-05-24 11:05:30 UTC
Let's patch?

Alternatively, BuildRequiring python3-crypt-r will solve this problem, as the package offers the crypt module on Python 3.13+

https://github.com/fedora-python/crypt_r

Comment 4 Martin Hoyer 2024-05-28 11:52:44 UTC
(In reply to Miro Hrončok from comment #3)
Thanks for looking into it Miro. The patch removing crypt from the upstream test was merged yesterday. 

Would you say it's better to add a temporary workaround or wait for an upstream release?

Comment 5 Miro Hrončok 2024-05-28 12:49:03 UTC
Considering this seems to be a leaf package, feel free to wait.

Comment 6 Karolina Surma 2024-06-12 15:06:39 UTC
*** Bug 2291884 has been marked as a duplicate of this bug. ***

Comment 7 Fedora Fails To Install 2024-06-19 19:59:24 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 8 Martin Hoyer 2024-06-20 12:17:54 UTC
Upstream release is not in sight. Will add backport the patch to Fedora today as a workaround.

Comment 9 Martin Hoyer 2024-06-20 17:14:09 UTC
Resolved by https://bodhi.fedoraproject.org/updates/FEDORA-2024-037a52bc15

Comment 10 Fedora Fails To Install 2024-06-21 00:11:05 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 41.

Thanks for taking care of it!