Bug 2279795

Summary:	Review Request: rust-gstreamer-allocators-sys - FFI bindings to libgstallocators-1.0
Product:	[Fedora] Fedora	Reporter:	Fabio Valentini <decathorpe>
Component:	Package Review	Assignee:	Ben Beasley <code>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	code, package-review
Target Milestone:	---	Flags:	code: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://crates.io/crates/gstreamer-allocators-sys
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2024-05-13 18:59:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	2279793

Description Fabio Valentini 2024-05-08 20:55:19 UTC

Spec URL: https://decathorpe.fedorapeople.org/rust-gstreamer-allocators-sys.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-gstreamer-allocators-sys-0.22.0-1.fc40.src.rpm

Description:
FFI bindings to libgstallocators-1.0.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2024-05-08 20:55:22 UTC

This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=117443614

Comment 2 Fedora Review Service 2024-05-08 21:07:15 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/7427816
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2279795-rust-gstreamer-allocators-sys/fedora-rawhide-x86_64/07427816-rust-gstreamer-allocators-sys/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Ben Beasley 2024-05-10 19:48:52 UTC

Looks OK to me. Approved. It’s a shame the test fix isn’t quite trivial to backport.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

The spec file is almost exactly as generated by (unconfigured) rust2rpm,
simplifying the review.

- Tests are disabled, with adequate justification via an upstream bug link.

- A pkg-config dependency on the gstreamer-allocators-1.0 library that this
  crate wraps is correctly added:

    (in the base package)
    +BuildRequires:  pkgconfig(gstreamer-allocators-1.0) >= 1.14
    (in each -devel subpackage)
    +Requires:       pkgconfig(gstreamer-allocators-1.0) >= 1.14

Issues:
=======
- If your application is a C or C++ application you must list a
  BuildRequires against gcc, gcc-c++ or clang.
  Note: No gcc, gcc-c++ or clang found in BuildRequires
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/

  Not an issue: this Rust crate library wraps a C API, but a direct/explicit
  dependency on a C or C++ compiler is not needed.

- Package does not contain duplicates in %files.
  Note: warning: File listed twice: /usr/share/cargo/registry/gstreamer-
  allocators-sys-0.22.0/CHANGELOG.md
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/#_duplicate_files

  This is not a serious problem; if it needs to be fixed, it should be done in
  rust2rpm.


===== MUST items =====

C/C++:
[-]: Provides: bundled(gnulib) in place as required.
     Note: Sources not installed
[x]: Package does not contain kernel modules.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Package contains no static executables.
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Apache License (v2.0) or MIT license
     and/or GNU Lesser General Public License and/or MIT License", "*No
     copyright* MIT License", "*No copyright* GNU Lesser General Public
     License v2.1 or later and/or MIT License". 12 files have unknown
     license. Detailed output of licensecheck in
     /home/ben/Downloads/review/2279795-rust-gstreamer-allocators-
     sys/licensecheck.txt

     The GPL/LGPL detections above are from language like this, in COPYRIGHT:

       This project provides interoperability with various GStreamer libraries but
       doesn't distribute any parts of them. Distributing compiled libraries and
       executables that link to those libraries may be subject to terms of the GNU
       LGPL or other licenses. For more information check the license of each
       GStreamer library.

     This can be considered an informational statement rather than an
     additional license restriction, and such considerations are not reflected
     in Fedora packages’s License tags. Somewhat related:
     https://docs.fedoraproject.org/en-US/legal/compatibility/

[x]: License file installed when any subpackage combination is installed.
[x]: Package requires other packages for directories it uses.
     Note: No known owner of /usr, /usr/share, /usr/share/cargo/registry,
     /usr/share/cargo

     Spurious diagnostics (fedora-review bug).

[x]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr, /usr/share/cargo,
     /usr/share/cargo/registry, /usr/share

     Spurious diagnostics (fedora-review bug).

[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 0 bytes in 0 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
     Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust-
     gstreamer-allocators-sys-devel , rust-gstreamer-allocators-
     sys+default-devel , rust-gstreamer-allocators-sys+v1_16-devel , rust-
     gstreamer-allocators-sys+v1_18-devel , rust-gstreamer-allocators-
     sys+v1_20-devel , rust-gstreamer-allocators-sys+v1_22-devel , rust-
     gstreamer-allocators-sys+v1_24-devel
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[!]: %check is present and all tests pass.

     Tests are disabled, but with adequate justification.

[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: rust-gstreamer-allocators-sys-devel-0.22.0-1.fc41.noarch.rpm
          rust-gstreamer-allocators-sys+default-devel-0.22.0-1.fc41.noarch.rpm
          rust-gstreamer-allocators-sys+v1_16-devel-0.22.0-1.fc41.noarch.rpm
          rust-gstreamer-allocators-sys+v1_18-devel-0.22.0-1.fc41.noarch.rpm
          rust-gstreamer-allocators-sys+v1_20-devel-0.22.0-1.fc41.noarch.rpm
          rust-gstreamer-allocators-sys+v1_22-devel-0.22.0-1.fc41.noarch.rpm
          rust-gstreamer-allocators-sys+v1_24-devel-0.22.0-1.fc41.noarch.rpm
          rust-gstreamer-allocators-sys-0.22.0-1.fc41.src.rpm
=========================================================================================== rpmlint session starts ==========================================================================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpapfb1w7v')]
checks: 32, packages: 8

rust-gstreamer-allocators-sys+default-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+default-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_16-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_16-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_18-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_18-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_20-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_20-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_22-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_22-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_24-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_24-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys.src: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys.src: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+default-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_16-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_18-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_20-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_22-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_24-devel.noarch: W: no-documentation
==================================================== 8 packages and 0 specfiles checked; 16 errors, 6 warnings, 37 filtered, 16 badness; has taken 0.6 s ====================================================




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 7

rust-gstreamer-allocators-sys+v1_22-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_22-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_18-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_18-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_16-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_16-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_24-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_24-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+default-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+default-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_20-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_20-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys-devel.noarch: E: spelling-error ('libgstallocators', 'Summary(en_US) libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys-devel.noarch: E: spelling-error ('libgstallocators', '%description -l en_US libgstallocators -> defibrillators')
rust-gstreamer-allocators-sys+v1_22-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_18-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_16-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_24-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+default-devel.noarch: W: no-documentation
rust-gstreamer-allocators-sys+v1_20-devel.noarch: W: no-documentation
 7 packages and 0 specfiles checked; 14 errors, 6 warnings, 33 filtered, 14 badness; has taken 0.3 s 



Source checksums
----------------
https://crates.io/api/v1/crates/gstreamer-allocators-sys/0.22.0/download#/gstreamer-allocators-sys-0.22.0.crate :
  CHECKSUM(SHA256) this package     : 061c7e61aae42f5437689f02d38e9a60b8c7e408ecb240a7e5a4c4bdeb54f4b0
  CHECKSUM(SHA256) upstream package : 061c7e61aae42f5437689f02d38e9a60b8c7e408ecb240a7e5a4c4bdeb54f4b0


Requires
--------
rust-gstreamer-allocators-sys-devel (rpmlib, GLIBC filtered):
    (crate(glib-sys/default) >= 0.19.0 with crate(glib-sys/default) < 0.20.0~)
    (crate(gobject-sys/default) >= 0.19.0 with crate(gobject-sys/default) < 0.20.0~)
    (crate(gstreamer-sys/default) >= 0.22.0 with crate(gstreamer-sys/default) < 0.23.0~)
    (crate(libc/default) >= 0.2.0 with crate(libc/default) < 0.3.0~)
    (crate(system-deps/default) >= 6.0.0 with crate(system-deps/default) < 7.0.0~)
    cargo
    pkgconfig(gstreamer-allocators-1.0)
    rust

rust-gstreamer-allocators-sys+default-devel (rpmlib, GLIBC filtered):
    cargo
    crate(gstreamer-allocators-sys)

rust-gstreamer-allocators-sys+v1_16-devel (rpmlib, GLIBC filtered):
    cargo
    crate(gstreamer-allocators-sys)
    pkgconfig(gstreamer-allocators-1.0)

rust-gstreamer-allocators-sys+v1_18-devel (rpmlib, GLIBC filtered):
    cargo
    crate(gstreamer-allocators-sys)
    crate(gstreamer-allocators-sys/v1_16)
    pkgconfig(gstreamer-allocators-1.0)

rust-gstreamer-allocators-sys+v1_20-devel (rpmlib, GLIBC filtered):
    cargo
    crate(gstreamer-allocators-sys)
    crate(gstreamer-allocators-sys/v1_18)
    pkgconfig(gstreamer-allocators-1.0)

rust-gstreamer-allocators-sys+v1_22-devel (rpmlib, GLIBC filtered):
    cargo
    crate(gstreamer-allocators-sys)
    crate(gstreamer-allocators-sys/v1_20)
    pkgconfig(gstreamer-allocators-1.0)

rust-gstreamer-allocators-sys+v1_24-devel (rpmlib, GLIBC filtered):
    cargo
    crate(gstreamer-allocators-sys)
    crate(gstreamer-allocators-sys/v1_22)
    pkgconfig(gstreamer-allocators-1.0)



Provides
--------
rust-gstreamer-allocators-sys-devel:
    crate(gstreamer-allocators-sys)
    rust-gstreamer-allocators-sys-devel

rust-gstreamer-allocators-sys+default-devel:
    crate(gstreamer-allocators-sys/default)
    rust-gstreamer-allocators-sys+default-devel

rust-gstreamer-allocators-sys+v1_16-devel:
    crate(gstreamer-allocators-sys/v1_16)
    rust-gstreamer-allocators-sys+v1_16-devel

rust-gstreamer-allocators-sys+v1_18-devel:
    crate(gstreamer-allocators-sys/v1_18)
    rust-gstreamer-allocators-sys+v1_18-devel

rust-gstreamer-allocators-sys+v1_20-devel:
    crate(gstreamer-allocators-sys/v1_20)
    rust-gstreamer-allocators-sys+v1_20-devel

rust-gstreamer-allocators-sys+v1_22-devel:
    crate(gstreamer-allocators-sys/v1_22)
    rust-gstreamer-allocators-sys+v1_22-devel

rust-gstreamer-allocators-sys+v1_24-devel:
    crate(gstreamer-allocators-sys/v1_24)
    rust-gstreamer-allocators-sys+v1_24-devel



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2279795 --mock-options=--dnf
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api, C/C++
Disabled plugins: Haskell, Ocaml, fonts, Perl, R, PHP, SugarActivity, Java, Python
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 4 Fabio Valentini 2024-05-13 16:18:26 UTC

Thank you for the review!

Comment 5 Fedora Admin user for bugzilla script actions 2024-05-13 16:21:52 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gstreamer-allocators-sys

Comment 6 Fedora Update System 2024-05-13 18:54:29 UTC

FEDORA-2024-158c4433ff (rust-gstreamer-allocators-0.22.0-1.fc41 and rust-gstreamer-allocators-sys-0.22.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-158c4433ff

Comment 7 Fedora Update System 2024-05-13 18:59:12 UTC

FEDORA-2024-158c4433ff (rust-gstreamer-allocators-0.22.0-1.fc41 and rust-gstreamer-allocators-sys-0.22.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.