Bug 2280106

Summary: Review Request: rust-tokio-tfo - TCP Fast Open (TFO) in Rust for tokio
Product: [Fedora] Fedora Reporter: Petr Menšík <pemensik>
Component: Package ReviewAssignee: Fabio Valentini <decathorpe>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: decathorpe, package-review
Target Milestone: ---Keywords: AutomationTriaged
Target Release: ---Flags: decathorpe: fedora-review+
Hardware: Unspecified   
OS: Unspecified   
URL: https://crates.io/crates/tokio-tfo
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2024-07-11 18:18:26 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 2277964    
Attachments:
Description Flags
The .spec file difference from Copr build 7436950 to 7436954 none

Description Petr Menšík 2024-05-11 22:27:19 UTC
Spec URL: https://pemensik.fedorapeople.org/rust-tokio-tfo.spec
SRPM URL: https://pemensik.fedorapeople.org/rust-tokio-tfo-0.2.2-1.fc41.src.rpm

Description:
TCP Fast Open (TFO) in Rust for tokio.

Fedora Account System Username: pemensik

Comment 1 Petr Menšík 2024-05-11 22:27:22 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=117576170

Comment 3 Fedora Review Service 2024-05-12 20:19:35 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7436950
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2280106-rust-tokio-tfo/fedora-rawhide-x86_64/07436950-rust-tokio-tfo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2024-05-12 20:20:00 UTC
Created attachment 2032810 [details]
The .spec file difference from Copr build 7436950 to 7436954

Comment 5 Fedora Review Service 2024-05-12 20:20:02 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/7436954
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2280106-rust-tokio-tfo/fedora-rawhide-x86_64/07436954-rust-tokio-tfo/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Fabio Valentini 2024-05-13 13:49:27 UTC
Looks good to me!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 7 Fabio Valentini 2024-07-05 17:13:48 UTC
Looks like this was never imported. Are you still interested in this package?

Comment 8 Petr Menšík 2024-07-09 16:17:40 UTC
Yes, still need that.

Comment 9 Fedora Admin user for bugzilla script actions 2024-07-11 07:00:54 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tokio-tfo

Comment 10 Fedora Update System 2024-07-11 18:15:42 UTC
FEDORA-2024-f4afaa3c23 (rust-tokio-tfo-0.3.1-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-f4afaa3c23

Comment 11 Fedora Update System 2024-07-11 18:18:26 UTC
FEDORA-2024-f4afaa3c23 (rust-tokio-tfo-0.3.1-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.