Bug 2280109

Puppet's regsubst function (specifically, the pattern-as-string signature variant) breaks with Ruby 3.3:
- https://github.com/puppetlabs/puppet-enterprise_issues/issues/8#issuecomment-2035524085 (re: not upgrading PE to Ruby 3.3 specifically because of this)
- vaguely related: https://github.com/puppetlabs/puppet/issues/9302

On the ruby side, the third argument to Regexp.new (encoding) was deprecated in Ruby 3.2, and removed completely in 3.3:
- https://bugs.ruby-lang.org/issues/18797

For my environment, the "fix" was to edit puppet/functions/regsubst.rb#regsubst_string and simply remove the encoding argument to Regexp.compile, but that's obviously incorrect; a real patch here would probably do a switch on the encoding enum and either forcibly set the string encoding, or add Regexp::NOENCODING to re_flags in the 'N' case.



Reproducible: Always

Steps to Reproduce:
Use the string variant of regsubst with puppet in Fedora 40.
Actual Results:  
It fails with:

Error while evaluating a Resource Statement, Evaluation Error: Error while evaluating a Function Call, wrong number of arguments (given 3, expected 1..2)

Expected Results:  
No error, manifest compilation completes as expected.